Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up scaladoc comments #184

Closed
ruebot opened this Issue Mar 20, 2018 · 3 comments

Comments

2 participants
@ruebot
Copy link
Member

ruebot commented Mar 20, 2018

@ruebot ruebot added the enhancement label Mar 20, 2018

@ruebot ruebot self-assigned this Mar 20, 2018

@ruebot ruebot added this to In Progress in 1.0.0 Release of AUT Mar 20, 2018

ruebot added a commit that referenced this issue Mar 20, 2018

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 20, 2018

Here all our warnings:

src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=55 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=66 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=70 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=74 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=78 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=87 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=91 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=95 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=104 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=108 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=112 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=116 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=125 column=8
src/main/scala/io/archivesunleashed/spark/rdd/RecordRDD.scala message=Public method must have explicit type line=129 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/DetectMimeTypeTika.scala message=If block needs braces line=33 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/StringUtils.scala message=Avoid using return line=34 column=21
src/main/scala/io/archivesunleashed/spark/matchbox/StringUtils.scala message=Avoid using return line=45 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/StringUtils.scala message=Avoid using return line=59 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/StringUtils.scala message=Avoid using null line=34 column=28
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=Avoid using null line=26 column=95
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=Avoid using null line=27 column=106
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=Avoid using null line=28 column=95
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=Avoid using null line=29 column=93
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=Avoid using null line=31 column=115
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=Avoid wildcard imports line=19 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/TweetUtils.scala message=The string literal "user" appears 4 times in the file. line=31 column=44
src/main/scala/io/archivesunleashed/spark/matchbox/package.scala message=Redundant braces after class definition line=22 column=15
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDomain.scala message=Avoid using return line=31 column=21
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDomain.scala message=Avoid using return line=38 column=40
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDomain.scala message=Avoid using null line=31 column=28
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDomain.scala message=Avoid using null line=32 column=23
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDomain.scala message=Avoid using null line=42 column=27
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImages.scala message=Magic Number line=36 column=86
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImages.scala message=Magic Number line=36 column=107
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImages.scala message=Regular expression matched 'println' line=45 column=21
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImages.scala message=Public method must have explicit type line=36 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImages.scala message=Avoid wildcard imports line=20 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/RemoveHttpHeader.scala message=Avoid using null line=37 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/RemoveHttpHeader.scala message=Regular expression matched 'println' line=36 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/RemoveHttpHeader.scala message=If block needs braces line=30 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractImageLinks.scala message=Avoid using return line=34 column=22
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=32 column=9
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=38 column=9
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Public method must have explicit type line=28 column=17
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Public method must have explicit type line=33 column=17
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Public method must have explicit type line=39 column=17
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Avoid wildcard imports line=19 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/TupleFormatter.scala message=Avoid wildcard imports line=22 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala message=Avoid using null line=58 column=68
src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala message=Avoid wildcard imports line=23 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala message=Avoid wildcard imports line=27 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala message=Avoid wildcard imports line=28 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/ComputeMD5.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=22 column=7
src/main/scala/io/archivesunleashed/spark/matchbox/ComputeImageSize.scala message=Avoid using return line=35 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/ComputeImageSize.scala message=Avoid using return line=39 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/ComputeImageSize.scala message=If block needs braces line=34 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractLinks.scala message=Avoid using return line=39 column=23
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractLinks.scala message=Avoid using return line=40 column=24
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractBoilerpipeText.scala message=If block needs braces line=32 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractBoilerpipeText.scala message=If block needs braces line=47 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractBoilerpipeText.scala message=Public method must have explicit type line=30 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractBoilerpipeText.scala message=Public method must have explicit type line=45 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGraphML.scala message=Avoid using return line=74 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGraphML.scala message=If block needs braces line=37 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGraphML.scala message=Avoid wildcard imports line=19 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGEXF.scala message=Avoid using return line=78 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGEXF.scala message=If block needs braces line=37 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGEXF.scala message=Avoid wildcard imports line=19 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/WriteGEXF.scala message=The string literal "\" />\n" appears 3 times in the file. line=53 column=49
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractGraph.scala message=Magic Number line=53 column=54
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractGraph.scala message=Public method must have explicit type line=88 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractGraph.scala message=Avoid wildcard imports line=20 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractGraph.scala message=Avoid wildcard imports line=21 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractGraph.scala message=Avoid wildcard imports line=23 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/NERCombinedJson.scala message=Magic Number line=57 column=40
src/main/scala/io/archivesunleashed/spark/matchbox/NERCombinedJson.scala message=Avoid using null line=61 column=74
src/main/scala/io/archivesunleashed/spark/matchbox/NERCombinedJson.scala message=Avoid wildcard imports line=25 column=0
src/main/scala/io/archivesunleashed/spark/matchbox/NERCombinedJson.scala message=Use : Unit = for procedures line=90 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/RemoveHTML.scala message=Public method must have explicit type line=30 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/DetectLanguage.scala message=If block needs braces line=30 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Object name does not match the regular expression '^[A-Z][A-Za-z]*$' line=29 column=7
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Avoid using return line=69 column=23
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Cyclomatic complexity of 16 exceeds max of 10 line=59 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=If block needs braces line=92 column=12
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Method is longer than 50 lines line=59 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Public method must have explicit type line=50 column=6
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Use braces in for comprehensions line=62 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Insert a space after the start of the comment line=85 column=14
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Insert a space after the start of the comment line=98 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Insert a space after the start of the comment line=99 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/NER3Classifier.scala message=Insert a space after the start of the comment line=104 column=8
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=38 column=41
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=39 column=36
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=39 column=39
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=40 column=36
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=40 column=39
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=41 column=43
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Magic Number line=42 column=38
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=If block needs braces line=36 column=4
src/main/scala/io/archivesunleashed/spark/matchbox/ExtractDate.scala message=Avoid wildcard imports line=27 column=2
src/main/scala/io/archivesunleashed/spark/archive/io/ArchiveRecord.scala message=Avoid using null line=36 column=29
src/main/scala/io/archivesunleashed/spark/archive/io/ArchiveRecord.scala message=Avoid using null line=37 column=31
src/main/scala/io/archivesunleashed/spark/archive/io/ArchiveRecord.scala message=If block needs braces line=39 column=2
src/main/scala/io/archivesunleashed/spark/archive/io/ArchiveRecord.scala message=If block needs braces line=41 column=7
src/main/scala/io/archivesunleashed/spark/archive/io/ArchiveRecord.scala message=If block needs braces line=92 column=4
src/test/scala/io/archivesunleashed/spark/ArcTest.scala message=Magic Number line=57 column=50
src/test/scala/io/archivesunleashed/spark/ArcTest.scala message=Magic Number line=58 column=50
src/test/scala/io/archivesunleashed/spark/ArcTest.scala message=Regular expression matched 'println' line=103 column=8
src/test/scala/io/archivesunleashed/spark/ArcTest.scala message=Avoid wildcard imports line=25 column=0
src/test/scala/io/archivesunleashed/spark/ArcTest.scala message=Avoid wildcard imports line=26 column=0
src/test/scala/io/archivesunleashed/spark/ArcTest.scala message=The string literal "200805" appears 3 times in the file. line=48 column=30
src/test/scala/io/archivesunleashed/spark/rdd/RecordRDDTest.scala message=Avoid wildcard imports line=25 column=0
src/test/scala/io/archivesunleashed/spark/rdd/RecordRDDTest.scala message=Avoid wildcard imports line=28 column=0
src/test/scala/io/archivesunleashed/spark/rdd/RecordRDDTest.scala message=The string literal "http://www.archive.org/" appears 4 times in the file. line=72 column=33
src/test/scala/io/archivesunleashed/spark/rdd/RecordRDDTest.scala message=The string literal "http://www.sloan.org" appears 4 times in the file. line=72 column=60
src/test/scala/io/archivesunleashed/spark/rdd/RecordRDDTest.scala message=The string literal "Please visit our website at" appears 4 times in the file. line=107 column=23
src/test/scala/io/archivesunleashed/spark/rdd/CountableRDDTest.scala message=Avoid wildcard imports line=24 column=0
src/test/scala/io/archivesunleashed/spark/rdd/CountableRDDTest.scala message=Avoid wildcard imports line=25 column=0
src/test/scala/io/archivesunleashed/spark/WarcTest.scala message=Magic Number line=55 column=12
src/test/scala/io/archivesunleashed/spark/WarcTest.scala message=Avoid wildcard imports line=27 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/RemoveHttpHeaderTest.scala message=Avoid using null line=31 column=33
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=There should be no space before a left bracket '[' line=39 column=44
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=There should be no space before a left bracket '[' line=43 column=36
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=There should be no space before a left bracket '[' line=44 column=39
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=Avoid wildcard imports line=22 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=Avoid wildcard imports line=25 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=Avoid wildcard imports line=26 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=The string literal "a" appears 3 times in the file. line=31 column=18
src/test/scala/io/archivesunleashed/spark/matchbox/TupleFormatterTest.scala message=The string literal "c" appears 3 times in the file. line=31 column=29
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Magic Number line=55 column=17
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Magic Number line=56 column=17
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Magic Number line=57 column=17
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Regular expression matched 'println' line=53 column=4
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Regular expression matched 'println' line=63 column=4
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Boolean expression can be simplified line=51 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Boolean expression can be simplified line=64 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Boolean expression can be simplified line=65 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Avoid wildcard imports line=27 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGEXFTest.scala message=Avoid wildcard imports line=28 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractTextFromPDFsTest.scala message=There should be no space before a left bracket '[' line=30 column=44
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractTextFromPDFsTest.scala message=Avoid wildcard imports line=23 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractTextFromPDFsTest.scala message=Avoid wildcard imports line=24 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractLinksTest.scala message=Avoid using null line=50 column=24
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractLinksTest.scala message=Avoid using null line=53 column=46
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractLinksTest.scala message=The string literal "Here is <a href=\"http://www.google.com\">a search engine</a>.\n" appears 3 times in the file. line=28 column=27
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractLinksTest.scala message=The string literal "http://www.foobar.org/index.html" appears 3 times in the file. line=39 column=78
src/test/scala/io/archivesunleashed/spark/matchbox/ComputeImageSizeTest.scala message=Import from illegal package line=23 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ComputeImageSizeTest.scala message=Magic Number line=29 column=30
src/test/scala/io/archivesunleashed/spark/matchbox/ComputeImageSizeTest.scala message=Magic Number line=29 column=34
src/test/scala/io/archivesunleashed/spark/matchbox/ComputeImageSizeTest.scala message=Avoid using null line=38 column=28
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Magic Number line=54 column=17
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Magic Number line=55 column=17
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Magic Number line=56 column=17
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Regular expression matched 'println' line=62 column=4
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Boolean expression can be simplified line=51 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Boolean expression can be simplified line=63 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Boolean expression can be simplified line=64 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Avoid wildcard imports line=27 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/WriteGraphMLTest.scala message=Avoid wildcard imports line=28 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/RemoveHTMLTest.scala message=Avoid using null line=39 column=53
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractEntitiesTest.scala message=Insert a space after the start of the comment line=35 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImagesTest.scala message=Line contains a tab line=51 column=29
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImagesTest.scala message=Line contains a tab line=52 column=10
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImagesTest.scala message=Line contains a tab line=53 column=10
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImagesTest.scala message=Magic Number line=50 column=61
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImagesTest.scala message=Avoid wildcard imports line=26 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractPopularImagesTest.scala message=Avoid wildcard imports line=27 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDomainTest.scala message=Avoid using null line=30 column=19
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDomainTest.scala message=Avoid using null line=34 column=31
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDomainTest.scala message=Avoid using null line=48 column=25
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDomainTest.scala message=Avoid using null line=49 column=39
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDomainTest.scala message=The string literal "index.html" appears 4 times in the file. line=30 column=5
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractImageLinksTest.scala message=Avoid using null line=50 column=18
src/test/scala/io/archivesunleashed/spark/matchbox/StringUtilsTest.scala message=Avoid using null line=28 column=20
src/test/scala/io/archivesunleashed/spark/matchbox/StringUtilsTest.scala message=Avoid using null line=35 column=25
src/test/scala/io/archivesunleashed/spark/matchbox/StringUtilsTest.scala message=Avoid wildcard imports line=22 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=37 column=67
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=38 column=63
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=38 column=65
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=39 column=63
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=39 column=65
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=40 column=69
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Magic Number line=41 column=71
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Avoid using null line=33 column=23
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=Avoid wildcard imports line=22 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractDateTest.scala message=The string literal "20151204" appears 16 times in the file. line=28 column=23
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractBoilerPipeTextTest.scala message=Avoid using null line=34 column=65
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=Boolean expression can be simplified line=83 column=15
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=Boolean expression can be simplified line=84 column=15
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=Avoid wildcard imports line=23 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=Avoid wildcard imports line=24 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=The string literal "epic.org" appears 4 times in the file. line=52 column=59
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=The string literal "20080430" appears 8 times in the file. line=55 column=55
src/test/scala/io/archivesunleashed/spark/matchbox/ExtractGraphTest.scala message=The string literal "deadlists.com" appears 12 times in the file. line=55 column=66
src/test/scala/io/archivesunleashed/spark/matchbox/RecordLoaderTest.scala message=Avoid wildcard imports line=26 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/RecordLoaderTest.scala message=Avoid wildcard imports line=29 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/RecordLoaderTest.scala message=Avoid wildcard imports line=30 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/RecordLoaderTest.scala message=Avoid wildcard imports line=32 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/RecordLoaderTest.scala message=Avoid wildcard imports line=33 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/RecordLoaderTest.scala message=Avoid wildcard imports line=34 column=1
src/test/scala/io/archivesunleashed/spark/matchbox/TweetUtilsTest.scala message=Boolean expression can be simplified line=45 column=11
src/test/scala/io/archivesunleashed/spark/matchbox/TweetUtilsTest.scala message=Boolean expression can be simplified line=66 column=13
src/test/scala/io/archivesunleashed/spark/matchbox/TweetUtilsTest.scala message=Avoid wildcard imports line=22 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/TweetUtilsTest.scala message=Avoid wildcard imports line=23 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/TweetUtilsTest.scala message=Avoid wildcard imports line=24 column=0
src/test/scala/io/archivesunleashed/spark/matchbox/TweetUtilsTest.scala message=Avoid wildcard imports line=25 column=0
src/test/scala/io/archivesunleashed/spark/utils/JsonUtilTest.scala message=Magic Number line=34 column=28
src/test/scala/io/archivesunleashed/spark/utils/JsonUtilTest.scala message=Avoid wildcard imports line=23 column=1
src/test/scala/io/archivesunleashed/spark/ArchiveRecordTest.scala message=Avoid wildcard imports line=24 column=0

If others want to work on this, feel free to do pull requests against branch issue-184.

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 21, 2018

@greebie if you have some downtime later this week, or want a break from graphpass, I think it would be a good idea to reconcile what you started working on here over here. A lot of the work you have done there will come in handy for the descriptions that we need. Once we have that, we can put in a PR to get it into master, and then we can worry about those style warnings later. I'll create a separate issue for that when it goes into master.

@greebie

This comment has been minimized.

Copy link
Contributor

greebie commented Mar 21, 2018

Thanks @ruebot. Want to get that done by today I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.