#70 - minor updates; fixed shellcheck warnings

- signed-off-by: trimstray <trimstray@gmail.com>
trimstray · Mar 13, 2019 · ce6fb713a22cb5005ff5422873beb04a7f741c2f · ce6fb71
1 parent ffa78bb
commit ce6fb713a22cb5005ff5422873beb04a7f741c2f
Unified Split

Showing with 12 additions and 7 deletions.

+11 −7 lib/DomainChainCheck

+1 −0 src/__init__
diff --git a/lib/DomainChainCheck b/lib/DomainChainCheck
@@ -43,7 +43,7 @@ function DomainChainCheck() {
  _ssl_domain_cert_chain_verify_num=$(echo "$_ssl_domain_cert_chain_verify" | wc -l)
-  
-  for i in $(seq 1 $_ssl_domain_cert_chain_verify_num) ; do
+  
+  for i in $(seq 1 "$_ssl_domain_cert_chain_verify_num") ; do
    _ssl_domain_cert_chain_verify_first=$(echo "$_ssl_domain_cert_chain_verify" | \
                    sed -n "${i}p" | cut -d "/" -f2- | cut -d "=" -f2-)
@@ -57,10 +57,10 @@ function DomainChainCheck() {
  _root_certificate_duplicate=0
-  
-  for i in $(seq 0 $(($_ssl_domain_cert_chain_verify_num - 1))) ; do
+  
+  for i in $(seq 0 $((_ssl_domain_cert_chain_verify_num - 1))) ; do
-  
-    _last_cert=$(($_ssl_domain_cert_chain_verify_num - 1))
-  
-    _last_cert_2=$(($_ssl_domain_cert_chain_verify_num - 2))
+  
+    _last_cert=$((_ssl_domain_cert_chain_verify_num - 1))
+  
+    _last_cert_2=$((_ssl_domain_cert_chain_verify_num - 2))
    if [[ "$i" -eq 0 ]] ; then
@@ -87,6 +87,7 @@ function DomainChainCheck() {
      if [[ "${_ssl_domain_cert_chain_verify_stack[$i]}" == "${_ssl_domain_cert_chain_verify_stack[$_last_cert]}" ]] ; then
+  
+        # shellcheck disable=SC2034
        _root_certificate_status=1
@@ -98,9 +99,10 @@ function DomainChainCheck() {
      fi
-  
-      # shellcheck disable=SC2044
+  
+      # shellcheck disable=SC2044,SC2154
      for j in $(find "$_ssl_ca_path" -name "*.pem") ; do
+  
+        # shellcheck disable=SC2116
        _root_certificate_cn=$(echo "${_ssl_domain_cert_chain_verify_stack[$i]}")
        # shellcheck disable=SC2154
@@ -166,9 +168,9 @@ function DomainChainCheck() {
  fi
-  
-  _last_cert_num=$(($_chain_of_trust_num - 1))
+  
+  _last_cert_num=$((_chain_of_trust_num - 1))
-  
-  for k in $(seq 0 $(($_chain_of_trust_num - 1))) ; do
+  
+  for k in $(seq 0 $((_chain_of_trust_num - 1))) ; do
    # shellcheck disable=SC2086,SC2154
    if [[ "$HTRACE_COLORS" == "off" ]] ; then
@@ -209,4 +211,6 @@ function DomainChainCheck() {
  echo
+  
+  return $_STATE
+  
+
 }
diff --git a/src/__init__ b/src/__init__
@@ -54,6 +54,7 @@ function __main__() {
  s_color="true"
  # Path to ssl certificates (CA).
+  
+  # shellcheck disable=SC2034
  local _ssl_ca_path="/etc/ssl/certs/"
  # Default 'curl' command.