Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include Patents #3757

Merged
merged 3 commits into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@joka-de
Copy link
Contributor

joka-de commented Oct 24, 2018

added a section for somewhat proper inclusion of patents in citations

include Patents
added a section for somewaht proper inclusion of patents in citations
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Oct 24, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Oct 24, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Oct 25, 2018

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Oct 28, 2018

@adam3smith, can you take a look? The whole <if variable="issued submitted" match="all"> conditional (https://github.com/citation-style-language/styles/pull/3757/files#diff-181ea5ab17da2889c3ac76e555189a10R330) looks a bit complicated, and can probably be removed if we hard-code "und" as a group delimiter instead of using the "and" term. (there are also three other DIN-1505-2 styles: https://www.zotero.org/styles?q=din-1505-2)

(PR didn't validate because of term="und")

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Oct 28, 2018

I'm fine with that conditional. Sure, you could do this with a group, but that saves one or two lines. The rest looks good. DIN patent citations are weird... I'm not sure how to even make sense of them in the other DIN styles so I'd leave it at this one.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Oct 28, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 0e04b35 into citation-style-language:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Oct 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.