Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate universite-du-quebec-a-montreal.csl #3955
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Feb 26, 2019
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Feb 26, 2019
|
|
| @@ -679,6 +702,11 @@ | |||
| <macro name="issued-year"> | |||
| <choose> | |||
| <if variable="issued"> | |||
| <choose> | |||
| <if type="book" match="all" variable="translator"> | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 27, 2019
Member
why are you testing for translator here? That seems odd for original date -- that's frequently for historic works (and you're not testing for translator below)
This comment has been minimized.
This comment has been minimized.
jjrondeau
Feb 27, 2019
Author
Contributor
Our style guide distinguishes between translated and untranslated books and it should not in my humble opinion. The guide will be reviewed about this. For now, I'm going to remove the "translator" condition.
| <group delimiter=" "> | ||
| <text term="by"/> | ||
| <names variable="reviewed-author"> | ||
| <name and="text" delimiter-precedes-last="never" et-al-min="8" et-al-use-first="6" et-al-subsequent-min="8" et-al-subsequent-use-first="6" et-al-use-last="true" initialize-with="."/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 27, 2019
Member
no need for the et al's here in name -- they'll get inherited from the bibliography element.
This comment has been minimized.
This comment has been minimized.
| </choose> | ||
| </macro> | ||
| <citation et-al-min="3" et-al-use-first="1" disambiguate-add-names="true" disambiguate-add-givenname="true" disambiguate-add-year-suffix="true" givenname-disambiguation-rule="primary-name" collapse="year"> | ||
| <citation et-al-min="3" et-al-use-first="1" initialize-with="." disambiguate-add-names="true" disambiguate-add-givenname="true" disambiguate-add-year-suffix="true" givenname-disambiguation-rule="primary-name" collapse="year"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 27, 2019
Member
I'd remove the initialize-with here -- afaict you have this on all names (and where you don't, you can add it) and people don't expect this on citation, so this will lead to all sorts of confusion in editing the style.
This comment has been minimized.
This comment has been minimized.
jjrondeau
Feb 27, 2019
Author
Contributor
I was thinking about initials that appear in citations when two authors must be disambiguated. I will remove it.
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 27, 2019
Member
You can add that to the name element as well (if it isn't already). They won't show up with form="short" unless for disambiguation.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Feb 27, 2019
|
|
adam3smith
merged commit 71cdff8
into
citation-style-language:master
Mar 3, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
|
thanks! |
jjrondeau commentedFeb 26, 2019
I made some changes, mainly concerning the original publication date for books and the entry of the composers and performer's names in the Author field, thus avoiding the use of the Note field.