Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

😟 There are some issues with your submission. Please check the test report for details.

😃 Your submission passed all our automated tests.

(replaces #3934, #3935, #3936; note that you can just update an existing pull request per the instructions above, so it wasn't necessary to create multiple pull requests)

@GluonDuGitHub, thanks. Is this something you came up yourself, or is there some kind of official style guide that describes a numbered APA variant? We generally only accept styles that are based on institutional requirements, to prevent too much proliferation of styles. See also https://github.com/citation-style-language/styles/wiki/Criteria-for-Accepting-Styles.

Thanks for clarifying. Yes, that should be acceptable. Could you use the GitHub website to attach the rules to a GitHub comment? Email attachments don't work here. See https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/.

We'll also probably want to name the style a little, to e.g. "IPAG Business School - APA", to better fit with our repository conventions, but I'll know better when I've had a chance to see the rules.

We'll also probably want to name the style a little, to e.g. "IPAG Business School - APA", to better fit with our repository conventions, but I'll know better when I've had a chance to see the rules.

I am not sure I understood what kind of rules you wanted to see (since the vade-mecum is in French, and considering that I am the one who defines it): would the description of this style as: "APA rules with a numbered bibliography" be ok?

In French is fine -- presumably what you tried to attach last time would have been perfect, we just never received it since you attached it to an e-mail reply rather than uploading it here on github.

Is that ok? (this is the part where I write about the style students should comply with)
ConsignesRedactionMemoire2019_2020.pdf

😟 There are some issues with your submission. Please check the test report for details.

😟 There are some issues with your submission. Please check the test report for details.

😟 There are some issues with your submission. Please check the test report for details.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

I have a couple of questions/comments about the style itself. Please take a look at those as well.

Could you please give some feedback about the changes I made and if I need to do more?

😃 Your submission passed all our automated tests.

Could you please give some feedback about the changes I made and if I need to do more?

I've one more question about the language of the style. Will it only be used for French?

Could you please give some feedback about the changes I made and if I need to do more?

I've one more question about the language of the style. Will it only be used for French?

Most of the time, students choose to write in French, but 10% choose English.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

Most of the time, students choose to write in French, but 10% choose English.

Okay, in that case we shouldn't fix the style to French, then. @adam3smith, this looks good to merge to me.

When you say you started from "Simon Kornblith's version of the style" could you specify this? He wrote the original APA CSL style many years ago so any version will have him as the author, but it looks like you started from an older one? Where did you get the version you started with from?

I'm asking specifically because

1. The sort key I asked about isn't in the current APA style (though I see you removed it; still puzzled where it came from)
2. The way you use the number variable for patents in in-text citations won't work (the examples you link to are right -- your code just won't produce them): a) number appears in several other item types (e.g. report) and will then also show up, incorrectly, in in-text citations and b) this will also incorrectly print author and title (which you need for the reference list for patents) in text for patents. This is handled correctly by the current APA style, so it'd be much easier to just use the latest version of apa.csl from this repository change the metadata and add your citation number code.

😃 Your submission passed all our automated tests.

When you say you started from "Simon Kornblith's version of the style" could you specify this? He wrote the original APA CSL style many years ago so any version will have him as the author, but it looks like you started from an older one? Where did you get the version you started with from?

I got this version from this page: https://csl.mendeley.com/searchByName/ and I chose the first link: https://csl.mendeley.com/styleInfo/?styleId=http%3A%2F%2Fwww.zotero.org%2Fstyles%2Fapa

1. The sort key I asked about isn't in the current APA style (though I see you removed it; still puzzled where it came from)
2. The way you use the number variable for patents in in-text citations won't work (the examples you link to are right -- your code just won't produce them): a) number appears in several other item types (e.g. report) and will then also show up, incorrectly, in in-text citations and b) this will also incorrectly print author and title (which you need for the reference list for patents) in text for patents. This is handled correctly by the current APA style, so it'd be much easier to just use the latest version of apa.csl from this repository change the metadata and add your citation number code.

I made a new version using the file I found here: https://github.com/citation-style-language/styles/blob/master/apa.csl and submitted this new version.

I thank you for your guidance and I hope this one will fulfill the requirements! :-)

Yes, much better, thanks. Didn't realize the styles on the Mendeley version of the CSL editor were quite that old.