Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hochschule-bonn-rhein-sieg.csl #3661

Merged
merged 15 commits into from Sep 5, 2018

Conversation

Projects
None yet
4 participants
@daryoush86
Copy link
Contributor

daryoush86 commented Aug 27, 2018

This style provides the required citation styles for students from the University of Applied Sciences Bonn-Rhein-Sieg, Department of Business Economics

Create Zitierstil der HBRS.csl
This style provides the required citation styles for students from the University of Applied Sciences Bonn-Rhein-Sieg, Department of Business Economics
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 27, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@daryoush86 daryoush86 closed this Aug 27, 2018

@daryoush86 daryoush86 reopened this Aug 27, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 27, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 27, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 27, 2018

😟 There are some issues with your submission. Please check the test report for details.

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Aug 27, 2018

Hi,

  1. Please add a "template" link to the style you based yours on in the style.
  2. Please add links to the documentation of the style.
  3. Run the style through and copy back. This will get rid of some formatting issues. http://formatter.citationstyles.org/
  4. For which languages is this style? Only German, only English, or both?
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@daryoush86 daryoush86 changed the title Create Zitierstil der HBRS.csl HBRS.csl Aug 28, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@daryoush86

This comment has been minimized.

Copy link
Contributor Author

daryoush86 commented Aug 28, 2018

The style is only for german. I tried to fix most of the change requests. However, it seems two issues remain. 1) the file name seems not to meet the requirements and 2) the template link is not accepted, even though it points exactly to the refered style template.

Grateful for any help

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@daryoush86 daryoush86 changed the title HBRS.csl hbrs.csl Aug 28, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@daryoush86 daryoush86 changed the title hbrs.csl hochschule-bonn-rhein-sieg.csl Aug 28, 2018

daryoush86 added some commits Aug 28, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😃 Your submission passed all our automated tests.

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Aug 28, 2018

You still need to do step 1 and 3. :)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😟 There are some issues with your submission. Please check the test report for details.

@daryoush86

This comment has been minimized.

Copy link
Contributor Author

daryoush86 commented Aug 28, 2018

Yes just finished with 1 and 3 :-). However, I still get that error for step 1. The template I used is located here: https://www.zotero.org/styles/deutsche-gesellschaft-fur-psychologie

However, the test tells me it is non-existent under this path

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Aug 28, 2018

that might be because of the s in https? Can you test?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 28, 2018

😃 Your submission passed all our automated tests.

@daryoush86

This comment has been minimized.

Copy link
Contributor Author

daryoush86 commented Aug 28, 2018

just tested and it seems to be alright now without the s in https. Thanks :-)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Sep 5, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit cea33b3 into citation-style-language:master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Sep 5, 2018

Danke!

@daryoush86, is there a webpage that links to https://www.h-brs.de/files/leitfaden_fuer_die_gestaltung_schriftlicher_arbeiten_2016_version_2.0.pdf? We try to avoid linking directly to PDFs (especially ones that have a date in the URL), since it can be hard for us to find the new link when the style guide is updated in the future.

@daryoush86

This comment has been minimized.

Copy link
Contributor Author

daryoush86 commented Sep 5, 2018

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Sep 8, 2018

@daryoush86, okay, in that case we'll just leave things as they are for now. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.