Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create american-school-of-classical-studies-at-athens.csl #3890

Merged
merged 3 commits into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@wallrodt
Copy link
Contributor

wallrodt commented Jan 25, 2019

This is the first version of the ASCSA style for Hesperia.
There is a custom abbreviations.json file to accompany this style. That file allows the use of the AJA (American Journal of Archaeology) abbreviations for Journals and Book Series (but not for Standard Reference Works). I don't know how to add that to this style.

Create american-school-of-classical-studies-at-athens.csl
There is a custom abbreviations.json file to accompany this style. I don't know how to add that.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 25, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 25, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 26, 2019

@wallrodt, thanks! A few questions:

  • Did you base this on the Ecology CSL style, or another style? Ecology is mentioned in this style's template link, but it doesn't look like that's right.
  • Style-specific abbreviation lists are a citeproc-js/Juris-M specific feature that isn't part of the official CSL specification, and we unfortunately currently don't support them.
  • Is http://athina.ascsa.edu.gr/pdf/uploads/Guidelines10-13.pdf an intranet webpage? I'm trying to access it but it doesn't load for me.
Update american-school-of-classical-studies-at-athens.csl
Updated the documentation URL for the style
@wallrodt

This comment has been minimized.

Copy link
Contributor Author

wallrodt commented Jan 28, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 28, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 2, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 2, 2019

The style-specific abbreviation is something that might be Zotero specific, which is my target audience. Many Classics related fields use the AJA abbreviations for bibliography, so this is a big part of the style.

Since we currently don't have a way to store and distribute custom abbreviation lists, you'll just have to provide your users with this file yourself for now. https://forums.zotero.org/discussion/comment/275237/#Comment_275237 suggests that Zotero users can use a custom abbreviations.json file by copying it into their Zotero data directory.

I hired someone to get the stylesheet started. I don’t know what template they started with.

@POBrien333, was that you by any chance? You're currently mentioned in the style. If it's just carry-over from another style I'll remove your name here.

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Feb 3, 2019

That was me.

@rmzelle rmzelle merged commit 30a5d10 into citation-style-language:master Feb 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 3, 2019

@POBrien333, thanks for clarifying. It looks like we can make a dependent for Hesperia, right? https://www.jstor.org/journal/hesperia

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Feb 3, 2019

Yes, let me check and submit a PR if.

POBrien333 added a commit to POBrien333/styles that referenced this pull request Feb 4, 2019

@POBrien333 POBrien333 referenced this pull request Feb 4, 2019

Merged

Create hesperia.csl #3912

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 5, 2019

@wallrodt, can you send us the abbreviations list?

You can either make a pull request at https://github.com/citation-style-language/abbreviations (file name doesn't really matter), or you can add the file here as an attachment to a GitHub comment. For the latter, note that email attachments don't work, and it looks like you'd have to give the JSON file a ".txt" extension (see https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/).

@wallrodt

This comment has been minimized.

Copy link
Contributor Author

wallrodt commented Feb 5, 2019

aja_abbreviations_json.txt
This should be renamed abbreviations.json and placed in the top level of the user's Zotero folder.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 5, 2019

aja_abbreviations_json.txt
This should be renamed abbreviations.json and placed in the top level of the user's Zotero folder.

Great, thanks. I uploaded this file at https://github.com/citation-style-language/abbreviations/blob/master/american-journal-of-archaeology/abbreviations.json. Clicking the "Raw" button gives you the actual file: https://raw.githubusercontent.com/citation-style-language/abbreviations/master/american-journal-of-archaeology/abbreviations.json

Can you also tell us where you found the list of AJA abbreviations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.