Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Harvard7de #2564

Merged
merged 5 commits into from Apr 1, 2017

Conversation

Projects
None yet
3 participants
@adam3smith
Copy link
Member

adam3smith commented Mar 13, 2017

and redirect to FH Voralberg. As discussed here: #74 (comment)

Delete Harvard7de
and redirect to FH Voralberg
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 13, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 13, 2017

😟 There are some issues with your submission. Please check the test report for details.

Fix renamed JSON
We still need to decide what to do with the templates, though
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 13, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 13, 2017

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member Author

adam3smith commented Mar 13, 2017

@rmzelle is that the right way to go, though? I don't think FHV is actually the basis for that style. Shouldn't we rather not use a template and move the Harvard7 creator into contributor?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 13, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Mar 13, 2017

Well, if either of the two styles need a rewrite in the future, it might make sense to base them on FHV, so the template link might still hold some value. But, yeah, what you propose is possible too. I'm fine with either.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 28, 2017

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member Author

adam3smith commented Mar 28, 2017

(fiddlestick; that commit wasn't supposed to go in this branch. I'll sort it out)

@adam3smith adam3smith force-pushed the harvard7-delete branch from d679155 to d6b1eb8 Apr 1, 2017

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 1, 2017

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit e09bfc0 into master Apr 1, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adam3smith adam3smith deleted the harvard7-delete branch Apr 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.