Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.66.0 #63

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@depfu
Copy link
Contributor

depfu bot commented Mar 19, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.65.0 → ~> 0.66.0) · Repo · Changelog

Release Notes

0.66.0

New features

  • #6393: Add AllowBracesOnProceduralOneLiners option to fine-tune Style/BlockDelimiter's semantic mode. (@davearonson)
  • #6383: Add AllowBeforeTrailingComments option on Layout/ExtraSpacing cop. (@davearonson)
  • New cop Lint/SafeNavigationWithEmpty checks for foo&.empty? in conditionals. (@rspeicher)
  • Add new Style/ConstantVisibility cop for enforcing visibility declarations of class and module constants. (@drenmi)
  • #6378: Add Lint/ToJSON cop to enforce an argument when overriding #to_json. (@allcentury)
  • #6346: Add auto-correction to Rails/TimeZone. (@dcluna)
  • #6840: Node patterns now allow unlimited elements after .... (@marcandre)

Bug fixes

  • #4321: Fix false offense for Style/RedundantSelf when the method is also defined on Kernel. (@mikegee)
  • #6821: Fix false negative for Rails/LinkToBlank when _blank is a symbol. (@Intrepidd)
  • #6699: Fix infinite loop for Layout/IndentationWidth and Layout/IndentationConsistency when bad modifier indentation before good method definition. (@koic)
  • #6777: Fix a false positive for Style/TrivialAccessors when using trivial reader/writer methods at the top level. (@koic)
  • #6799: Fix errors for Style/ConditionalAssignment, Style/IdenticalConditionalBranches, Lint/ElseLayout, and Layout/IndentationWidth with empty braces. (@pocke)
  • #6802: Fix auto-correction for Style/SymbolArray with array contains interpolation when EnforcedStyle is brackets. (@pocke)
  • #6797: Fix false negative for Layout/SpaceAroundBlockParameters on block parameter with parens. (@pocke)
  • #6798: Fix infinite loop for Layout/SpaceAroundBlockParameters with EnforcedStyleInsidePipes: :space. (@pocke)
  • #6803: Fix error for Style/NumericLiterals on a literal that contains spaces. (@pocke)
  • #6801: Fix auto-correction for Style/Lambda with no-space argument. (@pocke)
  • #6804: Fix auto-correction of Style/NumericLiterals on numeric literal with exponent. (@pocke)
  • #6800: Fix an incorrect auto-correct for Rails/Validation when method arguments are enclosed in parentheses. (@koic)
  • #6808: Prevent false positive in Naming/ConstantName when assigning a frozen range. (@drenmi)
  • Fix the calculation of Metrics/AbcSize. Comparison methods and else branches add to the comparison count. (@rrosenblum)
  • #6791: Allow Rails/ReflectionClassName to use symbol argument for class_name. (@unasuke)
  • #5465: Fix Layout/ClassStructure to allow grouping macros by their visibility. (@gprado)
  • #6461: Restrict Ctrl-C handling to RuboCop's loop and simplify it to a single phase. (@deivid-rodriguez)

Changes

  • Add $stdout/$stderr and STDOUT/STDERR method calls to Rails/Output. (@elebow)
  • #6688: Add iterator? to deprecated methods and prefer block_given? instead. (@tejasbubane)
  • #6806: Remove powerpack dependency. (@dduugg)
  • #6810: Exclude gemspec file by default for Metrics/BlockLength cop. (@koic)
  • #6813: Allow unicode/display_width dependency version 1.5.0. (@tagliala)
  • Make Style/RedundantFreeze aware of methods that will produce frozen objects. (@rrosenblum)
  • #6675: Avoid printing deprecation warnings about constants. (@elmasantos)
  • #6746: Avoid offense on $stderr.puts with no arguments. (@luciamo)
  • Replace md5 with sha1 for FIPS compliance. (@dirtyharrycallahan)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 19, 2019

@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Mar 24, 2019

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-0.66.0 branch from d59114c to 6441a44 Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.