Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cobertura-maven-plugin class issue; resolves #313. #314

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
3 participants
@ruebot
Copy link
Member

ruebot commented Mar 23, 2019

GitHub issue(s):

What does this Pull Request do?

Exclude slf4j binding logback-classic
(mojohaus/cobertura-maven-plugin#6 (comment))

How should this be tested?

  • Test should pass
  • We should still get a codecov.io report
  • If you build locally, (rm ~/.m2/repository/* ~/.ivy2 && mvn clean install), then;
  • We shouldn't see the classpath issue in #313 when using --jars

Interested parties

@edsu

@ruebot ruebot requested a review from jrwiebe Mar 23, 2019

@ruebot ruebot changed the title Resolve cobertura-maven-plugin class issue; resolves #133. Resolve cobertura-maven-plugin class issue; resolves #313. Mar 23, 2019

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 23, 2019

🤦‍♂️
I messed up the issue number in my original commit message. @jrwiebe if this gets merged, can you make sure the commit message in the GitHub interface is #313 instead of #133?

...or I can amend and force push 🤷‍♂️

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   75.84%   75.84%           
=======================================
  Files          41       41           
  Lines        1151     1151           
  Branches      202      202           
=======================================
  Hits          873      873           
  Misses        209      209           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a649e7...4023f62. Read the comment docs.

@jrwiebe jrwiebe merged commit 8504190 into master Mar 23, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 5a649e7...4023f62
Details
codecov/project 75.84% remains the same compared to 5a649e7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the issue-313-detroit branch Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.