[ISTC.js]: Replace (deprecated) for each loops (zotero#1203)

Also change inconsistent line endings to be in line with the rest of translators using `\n`
adam3smith · Dec 29, 2016 · 2b6221ed265ce0fb7fb6c5d12d59893236b28a62 · 2b6221e
1 parent efef794
commit 2b6221ed265ce0fb7fb6c5d12d59893236b28a62
Unified Split

Showing with 123 additions and 122 deletions.

+123 −122 ISTC.js
diff --git a/ISTC.js b/ISTC.js
@@ -9,130 +9,131 @@
 	"inRepository": true,
 	"translatorType": 4,
 	"browserSupport": "gcsibv",
-  
-	"lastUpdated": "2016-11-01 14:02:29"
+  
+	"lastUpdated": "2016-12-28 14:39:45"
 }
-  
-/*
-  
-	***** BEGIN LICENSE BLOCK *****
-  
-	
-  
-	RKE Web translator Copyright © 2016 Maike Kittelmann
-  
-	This file is part of Zotero.
-  
-	
-  
-	Zotero is free software: you can redistribute it and/or modify
-  
-	it under the terms of the GNU Affero General Public License as published by
-  
-	the Free Software Foundation, either version 3 of the License, or
-  
-	(at your option) any later version.
-  
-	
-  
-	Zotero is distributed in the hope that it will be useful,
-  
-	but WITHOUT ANY WARRANTY; without even the implied warranty of
-  
-	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  
-	GNU Affero General Public License for more details.
-  
-	
-  
-	You should have received a copy of the GNU Affero General Public License
-  
-	along with Zotero.  If not, see <http://www.gnu.org/licenses/>.
-  
-	
-  
-	***** END LICENSE BLOCK *****
-  
-*/
-  
-
-  
-
-  
-function detectWeb(doc, url) {
-  
-	if (url.indexOf('_search?') != -1 && getSearchResults(doc, true, url)) {
-  
-		return "multiple";
-  
-	} else if (url.search(/i[a-z]\d{8}/) != -1) {
-  
-		var title = ZU.trimInternal(ZU.xpath(doc, '//div[contains(@class, "ample-record")]/h3')[0].textContent);
-  
-		if (title) {
-  
-			return 'book';
-  
-		}
-  
-	}
-  
-}
-  
-
-  
-
-  
-function getSearchResults(doc, checkOnly, url) {
-  
-	var items = {};
-  
-	var found = false;
-  
-	var rows = ZU.xpath(doc, '//p[contains(@class, "ample-shortlist-item-entry")]/a[contains(@href, "/istc/i")]');
-  
-	for (i = 0; i < rows.length; i++) {
-  
-		var title = ZU.trimInternal(rows[i].textContent);
-  
-		var href = rows[i].href + '?format=json';
-  
-		if (!href || !title) continue;
-  
-		if (checkOnly) return true;
-  
-		found = true;
-  
-		items[href] = title;
-  
-	}
-  
-	return found ? items : false;
-  
-}
-  
-
-  
-
-  
-function doWeb(doc, url) {
-  
-	if (detectWeb(doc, url) == "multiple") {
-  
-		Zotero.selectItems(getSearchResults(doc, false, url), function(items) {
-  
-			if (!items) {
-  
-				return true;
-  
-			}
-  
-			var books = [];
-  
-			for (var i in items) {
-  
-				books.push(i);
-  
-			}
-  
-			ZU.doGet(Object.keys(items), scrape);
-  
-		});
-  
-	} else if (detectWeb(doc, url) == "book") {
-  
-		ZU.doGet(url + '?format=json', scrape);
-  
-	}
-  
-}
-  
-
-  
-
-  
-function scrape(response, obj, url) {
-  
-	var jsonObject = JSON.parse(response);
-  
-	var data = jsonObject.data;
-  
-	var item = new Zotero.Item('book');
-  
-
-  
-	var name = data.author;
-  
-	item.creators.push(Zotero.Utilities.cleanAuthor(name, "author", true))
-  
-
-  
-	item.title = data.title;
-  
-	item.url = url.replace('?format=json', '');
-  
-
-  
-	var imprint = data.imprint[0];
-  
-	item.place = (imprint.imprint_place || '');
-  
-	item.publisher = (imprint.imprint_name || '');
-  
-	item.date = (imprint.imprint_date || '');
-  
-
-  
-	if (data.notes) {
-  
-		item.notes.push(data.notes[0]);
-  
-	}
-  
-
-  
-	if (imprint.geo_info && imprint.geo_info[0].geonames_id) {
-  
-		item.notes.push('Geonames identifier of printing place: ' + imprint.geo_info[0].geonames_id);
-  
-	}
-  
-
-  
-	if (data.references) {
-  
-		var concatRef = '';
-  
-		for each(var ref in data.references) {
-  
-			var refName = (ref.reference_name || '');
-  
-			var refLoc = (ref.reference_location_in_source || '');
-  
-			concatRef += (refName + ' ' + refLoc + '; ');
-  
-		}
-  
-		concatRef = concatRef.replace(/; $/, '');
-  
-		item.notes.push('References: ' + concatRef);
-  
-	}
-  
-
-  
-	item.callNumber = 'ISTC ' + jsonObject._id;
-  
-	item.language = (data.language_of_item || '');
-  
-	item.libraryCatalog = 'Incunabula Short Title Catalogue (ISTC)';
-  
-	item.tags = ['incunabula', 'istc'];
-  
-	item.accessed = new Date().toString();
-  
-	// // Uncomment the following if you always want to save the page as attachment:
-  
-	//  item.attachments = [{
-  
-	//	url: url.replace('?format=json', ''),
-  
-	//	title: "ISTC",
-  
-	//	mimeType: "text/html",
-  
-	//	snapshot: true
-  
-	// }];		
-  
-	item.complete();
-  
-}
-  
-
-  
-
-  
-
+  
+/*
+  
+	***** BEGIN LICENSE BLOCK *****
+  
+	
+  
+	RKE Web translator Copyright © 2016 Maike Kittelmann
+  
+	This file is part of Zotero.
+  
+	
+  
+	Zotero is free software: you can redistribute it and/or modify
+  
+	it under the terms of the GNU Affero General Public License as published by
+  
+	the Free Software Foundation, either version 3 of the License, or
+  
+	(at your option) any later version.
+  
+	
+  
+	Zotero is distributed in the hope that it will be useful,
+  
+	but WITHOUT ANY WARRANTY; without even the implied warranty of
+  
+	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  
+	GNU Affero General Public License for more details.
+  
+	
+  
+	You should have received a copy of the GNU Affero General Public License
+  
+	along with Zotero.  If not, see <http://www.gnu.org/licenses/>.
+  
+	
+  
+	***** END LICENSE BLOCK *****
+  
+*/
+  
+
+  
+
+  
+function detectWeb(doc, url) {
+  
+	if (url.indexOf('_search?') != -1 && getSearchResults(doc, true, url)) {
+  
+		return "multiple";
+  
+	} else if (url.search(/i[a-z]\d{8}/) != -1) {
+  
+		var title = ZU.trimInternal(ZU.xpath(doc, '//div[contains(@class, "ample-record")]/h3')[0].textContent);
+  
+		if (title) {
+  
+			return 'book';
+  
+		}
+  
+	}
+  
+}
+  
+
+  
+
+  
+function getSearchResults(doc, checkOnly, url) {
+  
+	var items = {};
+  
+	var found = false;
+  
+	var rows = ZU.xpath(doc, '//p[contains(@class, "ample-shortlist-item-entry")]/a[contains(@href, "/istc/i")]');
+  
+	for (i = 0; i < rows.length; i++) {
+  
+		var title = ZU.trimInternal(rows[i].textContent);
+  
+		var href = rows[i].href + '?format=json';
+  
+		if (!href || !title) continue;
+  
+		if (checkOnly) return true;
+  
+		found = true;
+  
+		items[href] = title;
+  
+	}
+  
+	return found ? items : false;
+  
+}
+  
+
+  
+
+  
+function doWeb(doc, url) {
+  
+	if (detectWeb(doc, url) == "multiple") {
+  
+		Zotero.selectItems(getSearchResults(doc, false, url), function(items) {
+  
+			if (!items) {
+  
+				return true;
+  
+			}
+  
+			var books = [];
+  
+			for (var i in items) {
+  
+				books.push(i);
+  
+			}
+  
+			ZU.doGet(Object.keys(items), scrape);
+  
+		});
+  
+	} else if (detectWeb(doc, url) == "book") {
+  
+		ZU.doGet(url + '?format=json', scrape);
+  
+	}
+  
+}
+  
+
+  
+
+  
+function scrape(response, obj, url) {
+  
+	var jsonObject = JSON.parse(response);
+  
+	var data = jsonObject.data;
+  
+	var item = new Zotero.Item('book');
+  
+
+  
+	var name = data.author;
+  
+	item.creators.push(Zotero.Utilities.cleanAuthor(name, "author", true))
+  
+
+  
+	item.title = data.title;
+  
+	item.url = url.replace('?format=json', '');
+  
+
+  
+	var imprint = data.imprint[0];
+  
+	item.place = (imprint.imprint_place || '');
+  
+	item.publisher = (imprint.imprint_name || '');
+  
+	item.date = (imprint.imprint_date || '');
+  
+
+  
+	if (data.notes) {
+  
+		item.notes.push(data.notes[0]);
+  
+	}
+  
+
+  
+	if (imprint.geo_info && imprint.geo_info[0].geonames_id) {
+  
+		item.notes.push('Geonames identifier of printing place: ' + imprint.geo_info[0].geonames_id);
+  
+	}
+  
+
+  
+	if (data.references) {
+  
+		var concatRef = '';
+  
+		for (var i in data.references) {
+  
+			var ref = data.references[i];
+  
+			var refName = (ref.reference_name || '');
+  
+			var refLoc = (ref.reference_location_in_source || '');
+  
+			concatRef += (refName + ' ' + refLoc + '; ');
+  
+		}
+  
+		concatRef = concatRef.replace(/; $/, '');
+  
+		item.notes.push('References: ' + concatRef);
+  
+	}
+  
+
+  
+	item.callNumber = 'ISTC ' + jsonObject._id;
+  
+	item.language = (data.language_of_item || '');
+  
+	item.libraryCatalog = 'Incunabula Short Title Catalogue (ISTC)';
+  
+	item.tags = ['incunabula', 'istc'];
+  
+	item.accessed = new Date().toString();
+  
+	// // Uncomment the following if you always want to save the page as attachment:
+  
+	//  item.attachments = [{
+  
+	//	url: url.replace('?format=json', ''),
+  
+	//	title: "ISTC",
+  
+	//	mimeType: "text/html",
+  
+	//	snapshot: true
+  
+	// }];		
+  
+	item.complete();
+  
+}
+  
+
+  
+
+  
+
 /** BEGIN TEST CASES **/
 var testCases = [
 	{