Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

😃 Your submission passed all our automated tests.

Two small questions, but otherwise this looks good.

Hi, sorry for the mistakes, it is indeed standard French and not Canadian French but I did not know the locale for standard French as in Canada we consider that to be something else then FR-FR which we consider to be France-French and not standard French, the standard French being the central part of the language shared amongst all French locales (some parts of FR-FR but not all of it) but that is a political question…

Also for the subjects I think social_science and geography are the most appropriate.

Do I need to make the changes myles and if so how di I update the on git-hub?

Thanks

Dominic Villeneuve | Doctoral Assistant | Urban Sociology Lab (LaSUR)
Swiss Federal Institute of Technology Lausanne (EPFL) | Building BP 2 141
Email: dominic.villeneuve@epfl.chmailto://dominic.villeneuve@epfl.ch | Web: http://DominicVilleneuve.cahttp://dominicvilleneuve.ca/
Office: +41 (0) 21 693 62 67 | Mobile/WhatsApp: +41 (0)76 765 89 44

Le 21 juin 2016 à 04:22, Rintze M. Zelle <notifications@github.commailto:notifications@github.com> a écrit :

Two small questions, but otherwise this looks good.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2118#issuecomment-227323489, or mute the threadhttps://github.com/notifications/unsubscribe/ARstA-eLTvY7FZQHymZYZqDcWplUDOjTks5qN0rogaJpZM4I5vGs.

We'd ask you to make your changes in this pull request. See the instructions above, in particular

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (...) in the top-right corner of your style to start editing.

😃 Your submission passed all our automated tests.

looks good to me, I'll let @rmzelle do the final review&merge

See attached Zip file

I think you can only attach files via the GitHub website (not via email), see https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/. (updating the pull request like you did is much preferred, though)

it is indeed standard French and not Canadian French but I did not know the locale for standard French as in Canada we consider that to be something else then FR-FR which we consider to be France-French and not standard French, the standard French being the central part of the language shared amongst all French locales (some parts of FR-FR but not all of it) but that is a political question…

For CSL, I would recommend "fr-FR" for both standard French and France-French. We don't have a political opinion, but so far we've been able to manage with just two French CSL locale files ("fr-FR" and "fr-CA"), and I rather not add a third unless standard French is shown to deviate significantly from either one.

Style looks good now, thanks!

It is also customary for CSL to use geography-specific locale codes (e.g. "fr-FR") over general ones ("fr") as defaults, and I rather not change that in case it will break existing software. Just try to ignore it if it pains your sensibilities :).

Hi, I totally agree and made the change to fr-FR in the CSL, I’ll know for any future contribution and will keep ignoring it ;-)

Dominic Villeneuve | Assistant-doctorant | Laboratoire de Sociologie Urbaine (LaSUR)
École polytechnique fédérale de Lausanne (EPFL) | Bâtiment BP 2 141
Courriel: dominic.villeneuve@epfl.chmailto://dominic.villeneuve@epfl.ch | Web: http://DominicVilleneuve.cahttp://dominicvilleneuve.ca/
Bureau: +41 (0) 21 693 62 67 | Mobile/WhatsApp: +41 (0)76 765 89 44

Le 21 juin 2016 à 16:36, Rintze M. Zelle <notifications@github.commailto:notifications@github.com> a écrit :

It is also customary for CSL to use geography-specific locale codes (e.g. "fr-FR") over general ones ("fr") as defaults, and I rather not change that in case it will break existing software. Just try to ignore it if it pains your sensibilities :).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2118#issuecomment-227459706, or mute the threadhttps://github.com/notifications/unsubscribe/ARstAyN6DKBM0e9eEt01IVHwfBuCL_Xaks5qN_bkgaJpZM4I5vGs.