Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acta chirurgiae orthopaedica ACTA #2507

Merged
merged 3 commits into from Feb 18, 2017

Conversation

Projects
None yet
4 participants
@gehmert
Copy link
Contributor

gehmert commented Feb 16, 2017

Citation style for zotero for the journal Acta chirurgiae orthopaedica et traumatologiae Cechoslovaca

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 16, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 16, 2017

😟 There are some issues with your submission. Please check the test report for details.

@libora

This comment has been minimized.

Copy link
Contributor

libora commented Feb 16, 2017

@gehmert There is a lot of errors in your style. See https://travis-ci.org/citation-style-language/styles/builds/202193628. If you need any help see http://docs.citationstyles.org/en/stable/specification.html or contact me by email (libor.ansorge(at)volny.cz)

Update and rename dependent/Acta chirurgiae orthopaedica et traumatol…
…ogiae Cechoslovaca.csl to acta-chirurgiae-orthopaedicae-et-traumatologiae-cechoslovaca.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 17, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 17, 2017

@libora, actually, those errors were all due to the file name and the location (independent CSL styles like this one don't belong in the "dependent" subdirectory).

@gehmert, it looks like this journal publishes in Czech, Slovak, and English. Did you test it for multiple languages? Also, did you base this on another style? If so, we'd like to know which one, so we can add a "template" link (see https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link).

@gehmert

This comment has been minimized.

Copy link
Contributor Author

gehmert commented Feb 17, 2017

@libora

This comment has been minimized.

Copy link
Contributor

libora commented Feb 17, 2017

There so no differences in English and Czech/Slovak version of Literature part in instruction for authors on the web page of the journal. The English version of CSL style can be used for all languages.
Documentation is on http://www.achot.cz/pokyny.php in Czech or http://www.achot.cz/instruction.php in English

EDIT: czech (and probably slovak) language mutation of CSL will not work correctly due different abbreviation of "page" in locales.xml

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 17, 2017

@libora, so we can just fix the style to "en-GB" (British English)?

@libora

This comment has been minimized.

Copy link
Contributor

libora commented Feb 18, 2017

@rmzelle I think yes

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 18, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 1d9e0f9 into citation-style-language:master Feb 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 18, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.