Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate journal-of-historical-linguistics.csl #2562
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 10, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 10, 2017
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 10, 2017
|
adam3smith
requested changes
Mar 11, 2017
Thanks! I just went by a couple of examples, so let me know if there are other examples to the contrary and we can figure out together which make most sense in the context of the style |
@@ -28,7 +28,7 @@ | |||
</macro> | |||
<macro name="author"> | |||
<names variable="author"> | |||
<name delimiter-precedes-last="always" initialize="false" initialize-with="." name-as-sort-order="all" sort-separator=" "/> | |||
<name delimiter-precedes-last="always" initialize="false" initialize-with="." name-as-sort-order="first"/> |
This comment has been minimized.
This comment has been minimized.
<group prefix=" " suffix="."> | ||
<text term="in" text-case="capitalize-first" suffix=" "/> | ||
<names variable="editor translator" delimiter="," suffix=","> | ||
<name delimiter=" " and="symbol" delimiter-precedes-last="always" initialize-with="" name-as-sort-order="all" sort-separator=" "/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 11, 2017
Member
I'm not seeing initials in the bibliographies, so remove initialize-with=""
. I also see names in regular order, so remove the name-as-sort-order
. Finally, I'm not seeing a comma before the ampersand, so set delimiter-precedes-last="never"
I'm working off this example:
Might also be there are different ones? But this makes sense in the context of the style
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 11, 2017
Member
That same example also suggests that there shouldn't be an "in" and that the label should be before the name and be verb-short
.
<text variable="container-title" prefix=" " suffix="." font-style="italic"/> | ||
<text macro="publisher" prefix=" " suffix=", "/> | ||
<text variable="page" suffix="."/> | ||
<text variable="page" prefix=" " suffix="."/> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You'd have to change the "label" element in <else-if type="chapter paper-conference" match="any">
<text macro="title" prefix=" "/>
<group prefix=".">
<group>
<group prefix=" " suffix=".">
<text term="in" text-case="capitalize-first" suffix=" "/>
<names variable="editor translator" delimiter="," suffix=",">
<name delimiter=" " and="symbol" delimiter-precedes-last="always" initialize-with="" name-as-sort-order="all" sort-separator=" "/>
<label form="short" prefix=" "/>
</names>
<text variable="page" prefix=" " suffix="."/>
</group>
</group>
</group>
</else-if> to |
This comment has been minimized.
This comment has been minimized.
Thanks for reviewing this style. That chapter section was completely messed up. sorry. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 13, 2017
|
rmzelle
merged commit 6854027
into
citation-style-language:master
Mar 15, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
POBrien333 commentedMar 10, 2017
via error request: https://forums.zotero.org/discussion/comment/271743/#Comment_271743
It should come out as In Hall PA & Soskice D, eds., (comma between names and label), but comes out as In Hall PA & Soskice D eds.,
Am I missing something?