Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for "sentence" case on title and container-title #2613

Merged
merged 2 commits into from Apr 2, 2017

Conversation

Projects
None yet
3 participants
@rmzelle
Copy link
Member

rmzelle commented Apr 1, 2017

(follow-up of #2609)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 1, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 1, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 1, 2017

😃 Your submission passed all our automated tests.

end
end
end

This comment has been minimized.

@rmzelle

rmzelle Apr 1, 2017

Author Member

@adam3smith, the logic is not the most elegant, but RSpec is still mostly a mystery to me. It seems to work and doesn't seem to be particularly slow, so I guess it's okay.

@rmzelle

This comment has been minimized.

Copy link
Member Author

rmzelle commented Apr 1, 2017

@adam3smith, I'll leave this for you to merge. Looks like your earlier find-and-replace didn't catch all the cases.

@adam3smith adam3smith merged commit 800c787 into master Apr 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Apr 2, 2017

Looks good to me. Thanks -- yes, I used an overly simplistic sed.

@rmzelle rmzelle deleted the test-against-sentence-case branch Apr 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.