Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate ecological-restoration.csl #2971
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Sep 21, 2017
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Sep 21, 2017
|
|
adam3smith
reviewed
Sep 26, 2017
| <choose> | ||
| <if type="article-journal article-magazine article-newspaper" match="any"> | ||
| <choose> | ||
| <if match="all" variable="page issued"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Sep 26, 2017
Member
Are "page issued" really the best variables here? Wouldn't "page volume" make more sense here?
adam3smith
reviewed
Sep 26, 2017
| </group> | ||
| </layout> | ||
| </citation> | ||
| <bibliography entry-spacing="0" hanging-indent="true" delimiter-precedes-last="contextual"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Sep 26, 2017
Member
remove the delimiter-precedes-last here: it doesn't do anything (as this is the default) and this isn't a good place to set it, either.
adam3smith
reviewed
Sep 26, 2017
| <text variable="volume" prefix=" "/> | ||
| <text variable="page" prefix=":"/> | ||
| </if> | ||
| <else> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Sep 26, 2017
Member
You almost certainly would still want the container-title for early publication items, right?
This comment has been minimized.
This comment has been minimized.
|
A couple of small comments/questions above (sorry for the multiple notifications, I thought I just had one & wasn't going to use review mode but then spotted a couple of other potential issues). |
This comment has been minimized.
This comment has been minimized.
|
(metadata looks good to me) |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Sep 26, 2017
|
|
rmzelle
merged commit 92e1073
into
citation-style-language:master
Sep 27, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
POBrien333 commentedSep 21, 2017
via https://forums.zotero.org/discussion/67745/style-request-ecological-restoration