New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create international-security.csl #3713

Merged

adam3smith merged 9 commits into citation-style-language:master from POBrien333:patch-401

Oct 29, 2018

Contributor

POBrien333 commented Sep 28, 2018 •

edited by rmzelle

via https://forums.zotero.org/discussion/73834/style-request-international-security

Maybe this is a good opportunity to help me understand these extremely boxed styles better.

How do I achieve this (comma before Vol. 40 and : before doi):

Current: John L. Campbell and Ove K. Pedersen, “The Varieties of Capitalism and Hybrid Success,” Comparative Political Studies Vol. 40, No. 3 (March 1, 2007): pp. 307–32, doi:10.1177/0010414006286542.

Wanted: John L. Campbell and Ove K. Pedersen, "The varieties of capitalism and hybrid success," Comparative Political Studies, Vol. 40, No. 3 (2007), pp. 307, doi.org/10.1177/0010414006286542


      Create international-security.csl

via https://forums.zotero.org/discussion/73834/style-request-international-security#latest

Maybe this is a good opportunity to help me understand these styles.
How do I achieve this:
Current: John L. Campbell and Ove K. Pedersen, “The Varieties of Capitalism and Hybrid Success,” <i>Comparative Political Studies</i> Vol. 40, No. 3 (March 1, 2007): pp. 307–32, doi:10.1177/0010414006286542.
Wanted: John L. Campbell and Ove K. Pedersen, "The varieties of capitalism and hybrid success." <i>Comparative Political Studies</i>, Vol. 40, No. 3 (2007), p. 307, doi.org/10.1177/0010414006286542

da9c4b7

csl-bot commented Sep 28, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot commented Sep 28, 2018

😃 Your submission passed all our automated tests.


      Some touch-ups, remove bibliography

(build will fail bc of unused macros)

b1105bb

Member

adam3smith commented Sep 29, 2018

See changes above:
For the comma before the volume, you figure out that the volume is in a "join-with-space" macro for journal articles and then move it to the corresponding "join-with-comma" one, which in this case allows for significant simplifications.

For the comma before pages (not DOI): note that this is a locator, not a page range. The style already does a comma there.

I also removed the bibliography; you'll still need to do some clean-up here after that since there will be unused macros.

csl-bot commented Sep 29, 2018

😟 There are some issues with your submission. Please check the test report for details.


      Update international-security.csl

b4276f3

Contributor Author

POBrien333 commented Sep 30, 2018

thanks, Sebastian. Let's see next time if I can figure this out. :)

csl-bot commented Sep 30, 2018

😟 There are some issues with your submission. Please check the test report for details.


      Update international-security.csl

52c4fcc

csl-bot commented Sep 30, 2018

😟 There are some issues with your submission. Please check the test report for details.


      Update international-security.csl

c439695

csl-bot commented Sep 30, 2018

😟 There are some issues with your submission. Please check the test report for details.


      Update international-security.csl

561b424

csl-bot commented Sep 30, 2018

😟 There are some issues with your submission. Please check the test report for details.


      Update international-security.csl

2a8851d

csl-bot commented Sep 30, 2018

😟 There are some issues with your submission. Please check the test report for details.


      Update international-security.csl

ac12813

csl-bot commented Sep 30, 2018

😃 Your submission passed all our automated tests.


      Some fixes

- default locale
- locators&page numbers with comma
- all locators have a label

03e7211

csl-bot commented Oct 29, 2018

😃 Your submission passed all our automated tests.

adam3smith merged commit `5ff43de` into citation-style-language:master Oct 29, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.