Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iso690-author-date-es.csl #3829

Merged
merged 4 commits into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@franpra
Copy link
Contributor

franpra commented Dec 14, 2018

Please substitute after-collapse-delimiter=" ; " for after-collapse-delimiter="; " (no space before semicolon) in line 308. This is in accordance with the style specifications for multiple citations in an in-text citation. Thank you.

Update iso690-author-date-es.csl
Please substitute after-collapse-delimiter=" ; " for after-collapse-delimiter="; " (no space before semicolon) in line 308. This is in accordance with the style specifications for multiple citations in an in-text citation. Thank you.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 14, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 14, 2018

😃 Your submission passed all our automated tests.

add new documentation link
I've also wayback machined the link to be sure.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 14, 2018

😃 Your submission passed all our automated tests.

@franpra

This comment has been minimized.

Copy link
Contributor

franpra commented on 9d78d94 Dec 14, 2018

Please do not use the second URL added as documentation for this style, as it is an unauthorized -illegal- upload of that copyrighted document. Please update the first URL -which you suggest to delete- with this: https://www.aenor.com/normas-y-libros/buscador-de-normas/UNE?c=N0051162

This comment has been minimized.

Copy link
Member Author

adam3smith replied Dec 14, 2018

we need to be able to check on a style's correctness without paying 62 euros, though... we could use http://uc3m.libguides.com/guias_tematicas/citas_bibliograficas/une-iso-690 instead ?

This comment has been minimized.

Copy link
Contributor

franpra replied Dec 14, 2018

Of course, I understand. Yes, I believe the link you are suggesting may act as an acceptable surrogate for the actual standard. Would it be possible to include both links in the code, that is, the one from aenor and the one from uc3m.libguides? I think that would be the most honest thing to do.

Update iso690-author-date-es.csl
I have just updated documentation link, as commented in the corresponding commit.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 14, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 14, 2018

😃 Your submission passed all our automated tests.

@franpra

This comment has been minimized.

Copy link
Contributor

franpra commented on fb44ce4 Dec 14, 2018

Excellent! Thank you!

@adam3smith adam3smith merged commit 9f1963e into citation-style-language:master Dec 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Dec 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.