Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create national-science-foundation-proposals.csl #3916

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@pgugger
Copy link

pgugger commented Feb 6, 2019

NSF style that is a little simpler and cleaner than another existing one.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 6, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 6, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 8, 2019

Would you mind giving some comparison examples between this and https://github.com/citation-style-language/styles/blob/master/national-science-foundation-grant-proposals.csl? I wonder if we shouldn't just update the latter. They're both for the same type of grant proposals, right?

(we're aware that space is of a particular premium in these proposals)

@pgugger

This comment has been minimized.

Copy link
Author

pgugger commented Feb 12, 2019

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 12, 2019

@adam3smith, looks like an improvement to me. Shall we just replace the old one?

@stale

This comment has been minimized.

Copy link

stale bot commented Mar 14, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Mar 14, 2019

adam3smith added a commit that referenced this pull request Mar 17, 2019

NSF update
closes #3916

@adam3smith adam3smith referenced this pull request Mar 17, 2019

Merged

NSF update #3993

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 17, 2019

Thanks. I changed the DOI/URL logic a bit so that it only prints one of them (and prints the DOI as a link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.