Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check only modified files in CI #1900

Closed
dstillman opened this Issue Mar 7, 2019 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dstillman @retorquere
@dstillman
Copy link
Member

dstillman commented Mar 7, 2019

Unless and until we go through all translators to fix linter errors (which I'm in no rush to do), we're never going to have passing tests. It would be more useful (and it would certainly be quicker) to run ESLint only against the files modified in the commit range, so that we can rely on the checks on GitHub without having to check the output.

#1895 probably needs to land first.

/cc @retorquere
@retorquere

This comment has been minimized.

Sign in to view
Copy link
Contributor

retorquere commented Mar 7, 2019

This is possible. It'd build on work in #1895 though, and I'm in no hurry to do cross-branch work given recent experience.
@retorquere

This comment has been minimized.

Sign in to view
Copy link
Contributor

retorquere commented Mar 27, 2019

I don't think it'd require any changes when #1895 is done; adding a script line like

"travis": "teslint `git diff --name-only $TRAVIS_COMMIT_RANGE | grep -v '\\/' | grep '\.js$'`",

and then calling npm run travis should do it.
@retorquere

This comment has been minimized.

Sign in to view
Copy link
Contributor

retorquere commented Mar 27, 2019

or just

npm run lint -- `git diff --name-only $TRAVIS_COMMIT_RANGE | grep -v '\\/' | grep '\.js$'`

in .travis.yml rather than npm test.

retorquere added a commit to retorquere/translators that referenced this issue Mar 28, 2019

@retorquere
fixes zotero#1900
7b8cc9f

retorquere added a commit to retorquere/translators that referenced this issue Mar 28, 2019

@retorquere
Runs eslint only on changed translators (closes zotero#1900)
737f79e

@dstillman dstillman closed this in f67b9c5 Mar 28, 2019

GuyAglionby added a commit to GuyAglionby/translators that referenced this issue Mar 30, 2019

@retorquere @GuyAglionby
Runs eslint only on changed translators (closes zotero#1900) (zotero#… 
…1915)
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
0d02d52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.