Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Journal System #1110

Merged
merged 2 commits into from Aug 19, 2016

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Aug 18, 2016

This closes #1109

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Aug 19, 2016

But it's not worth switching Contracorriente to OJS entirely?

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Aug 19, 2016

The metadata from Contracorriente is currently very poor (see output of the current translator). Therefore I switched to BibTeX, which will give good metadata. However, I tried hard and it seems that every other OJS instance has good embedded metadata.

IMO the possibilities are:

  1. Copy the bibtex part to OJS translator and delete Contracorriente translator. However, this bibtex part will only be used for website of Contracorriente.
  2. Use the OJS translator as it is now for Contracorriente, but this will give very bad data.
  3. Use a separate translator for Contracorriente because it is a special OJS instance and handle it there.

First I tried 1. but then decided to switch to 3. which seems more logical for me.

@adam3smith adam3smith merged commit c782bbb into zotero:master Aug 19, 2016

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Aug 19, 2016

OK great, thanks!

@zuphilip zuphilip deleted the zuphilip:ojs branch Aug 19, 2016

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Open Journal System (zotero#1110)
* OJS: Improve detectWeb and add more test cases

* [Contracorriente]: Change to use BibTeX instead EM

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Open Journal System (zotero#1110)
* OJS: Improve detectWeb and add more test cases

* [Contracorriente]: Change to use BibTeX instead EM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.