Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes #1138

Merged
merged 12 commits into from Sep 9, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Copy link
Collaborator

zuphilip commented Sep 8, 2016

Here is B and one of C (because I noticed some potential problems in errors).
Embedded Metadata.js
@@ -1223,38 +1184,6 @@ var testCases = [
},
{
"type": "web",
"url": "http://books.upress.virginia.edu/title/4539",

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Sep 8, 2016

Author Collaborator

There are no metadata on this site.
Embedded Metadata.js
@@ -807,51 +809,6 @@ var exports = {
var testCases = [
{
"type": "web",
"url": "http://acontracorriente.chass.ncsu.edu/index.php/acontracorriente/article/view/174",

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Sep 8, 2016

Author Collaborator

This is covered by a special translator.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Sep 9, 2016

Great -- take a quick look to make sure you're OK with my two changes (this really is very handy, glad you mentioned it!)
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Sep 9, 2016

Yes, your changes are fine and improve the PR. Thank you. Looks good for me.

@adam3smith adam3smith merged commit 1eaf013 into zotero:master Sep 9, 2016

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Sep 9, 2016

Thanks (I did see and check the Beck update)

@zuphilip zuphilip deleted the zuphilip:more-fixes branch Sep 9, 2016

@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Sep 9, 2016

Thank you. The collaboration feature in PR on github is handy. I think this way we can work much more together on a feature, which is nice.

(Yes, beck-online is just restricted to subscribers and on-campus networks, i.e. the tests on your side will still fail.)

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Translator fixes B (zotero#1138) 
* Fix error when volumes is not present in Cairn.info.js

* Fix tests in Beobachter.js

* Fix tests in Biblio.com.js

* Update tests in BioMed Central.js

* Rewrite Bloomberg.js, skip empty authors in EM

 * Similar to highwire code in EM also empty are now skiped
 * Update test cases
 * Note that the multiple test in Bloomberg.js does not work
in the test pane, but the test website for multiples works
when called separately.

* Update tests in BOFiP-Impots.js

* Update tests in Boston Review.js

* Fixes and update tests in Business Standard.js

* BusinessWeek.js --> Bloomberg.js

The acquisition was in late 2009:
https://en.wikipedia.org/wiki/Bloomberg_Businessweek#Bloomberg_L.P._acquisition

* Update Beobachter.js

* Fix and update beck-online.js
0e50e23

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Translator fixes B (zotero#1138) 
* Fix error when volumes is not present in Cairn.info.js

* Fix tests in Beobachter.js

* Fix tests in Biblio.com.js

* Update tests in BioMed Central.js

* Rewrite Bloomberg.js, skip empty authors in EM

 * Similar to highwire code in EM also empty are now skiped
 * Update test cases
 * Note that the multiple test in Bloomberg.js does not work
in the test pane, but the test website for multiples works
when called separately.

* Update tests in BOFiP-Impots.js

* Update tests in Boston Review.js

* Fixes and update tests in Business Standard.js

* BusinessWeek.js --> Bloomberg.js

The acquisition was in late 2009:
https://en.wikipedia.org/wiki/Bloomberg_Businessweek#Bloomberg_L.P._acquisition

* Update Beobachter.js

* Fix and update beck-online.js
eb19896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.