Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Updates - G #1153

Merged
merged 3 commits into from Oct 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Copy link
Collaborator

zuphilip commented Sep 21, 2016

No description provided.

zuphilip added some commits Sep 21, 2016

@zuphilip
Rewrite Gallica.js
4af9a45
@zuphilip
Fix Google Play.js 
One needs to update the tests, but the output
differs from the location, i.e. one has to do
this from within the US.
460246c
@zuphilip
Fix multiples in Google Patents.js 
One needs to update the tests, but the output
differs from the location, i.e. one has to do
this from within the US.
668e89a

@adam3smith adam3smith merged commit 76d2bfe into zotero:master Oct 15, 2016

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Oct 15, 2016

Thanks -- all caught up with your large PRs
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented Oct 15, 2016

Maybe you can update the tests in GooglePlay and GooglePatents (I had some remarks hidden in the commit messages). The tests perform differently depending on the location and I guess US would be our default-location for testing.

@zuphilip zuphilip deleted the zuphilip:fixes-G branch Oct 15, 2016

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes and Updates - G (zotero#1153) 
* Rewrite Gallica.js
* Fix Google Play.js
One needs to update the tests, but the output
differs from the location, i.e. one has to do
this from within the US.

* Fix multiples in Google Patents.js
One needs to update the tests, but the output
differs from the location, i.e. one has to do
this from within the US.
b6d22fa

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes and Updates - G (zotero#1153) 
* Rewrite Gallica.js
* Fix Google Play.js
One needs to update the tests, but the output
differs from the location, i.e. one has to do
this from within the US.

* Fix multiples in Google Patents.js
One needs to update the tests, but the output
differs from the location, i.e. one has to do
this from within the US.
f6404b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.