Why do we have here duplicate tags?

Look at the MARC here: http://sallypro.sandiego.edu/iii/encore/record/C__Rb1516899__Stesting__P0,2__Orightresult__U__X6?lang=eng&suite=cobalt&marcData=Y
in the 650 fields:
650 0 Nursing|xEducation
650 0 Critical thinking
650 0 Constructivism (Education)
650 0 Nursing|xDecision making
650 0 Nursing|xPhilosophy

MARC imports both parts of the field as tag -- maybe that's not right? Or we should save the category in the 0 field and check against it to avoid duplication? In any case, this is a MARC issue, I'd like to address it separately

Okay, I see.

Although, I thought that duplicate tags were technically not possible. At least manually I cannot enter twice the same tag.

Turns out they only show up in the tests, not in Zotero itself.

ok

Did you add these tests with Scaffold? The [{ is usually on two lines...

of course tests are from scaffold, yes. I think this was jsbeautify which I ran on the whole file.

Ah, okay. For test it makes IMO sense to leave the formatting as Scaffold outputs it. Otherwise this will show differences the next time someone is updating and testing the same translator.

For a rewrite we should IMO increase the minVersion also to 3.0.

Add all of them (or do you have any reasons that they should not work?).

Missing ;

Missing ;

Fix typo linee (or do I miss the point in the variable name here?).

Can we add comment here, e.g. // skip empty line?

This is IMO quite confusing and tagValue is not yet initialized.

I suggest to actually clean the text before splitting into lines with something like:

				// delete empty lines, delete confusing newlines, e.g. 
				// 245 10 Testing a theoretical model of critical thinking and 
                		//        cognitive development /|cby Jane Rapps 
				text = text.replace(/^\n/mg, '').replace(/\s?\n\s+/gm, ' ');