Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Air University Journals #1494

Merged
merged 5 commits into from Dec 11, 2017

Conversation

Reviewers

@zuphilip zuphilip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adam3smith @zuphilip
@adam3smith
Copy link
Collaborator

adam3smith commented Dec 9, 2017 •
edited by zuphilip

ASJP and SSQ -- lot's of scraping, and authors and abstract can be
inconsistent, but rest should be solid.

adam3smith added some commits Dec 3, 2017

@adam3smith
Quick fix for Google Books Multiples 
This might be due for a re-write -- lots of legacy code here, but that
requires checking lots of cases as translator accommodates lots of
different views&errors
Loading status checks…
17ee255
@adam3smith
Merge branch 'master' of github.com:zotero/translators
c7c0b2a
@adam3smith
Merge branch 'master' of github.com:zotero/translators
e56d8c8
@adam3smith
Add Air University 
ASJP and SSQ -- lot's of scraping, and authors and abstract can be
inconsisten, but rest should be solid.
Loading status checks…
7ae29be

@adam3smith adam3smith requested a review from zuphilip Dec 9, 2017

@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator

zuphilip commented Dec 11, 2017

The AGPL was missing and I added it in your name. Please have a look. I added also the functions text and attr which were missing. Moreover, I improved the authors handling, e.g. to extract all three authors in Maj Gen (sel) Bradley D. Spacy, USAF / Mr. Edwin H. Oshiba, USAF / Capt Nicholas J. Thomas, USAF, PE. Okay?
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

adam3smith commented Dec 11, 2017

Cool, thanks!

@adam3smith adam3smith merged commit 8c58a9e into zotero:master Dec 11, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adam3smith added a commit to adam3smith/translators that referenced this pull request Dec 21, 2017

@adam3smith
Add Air University Journals (zotero#1494) 
* Add Air University

ASJP and SSQ -- lot's of scraping, and authors and abstract can be
inconsisten, but rest should be solid.
0e019b3

adam3smith added a commit to adam3smith/translators that referenced this pull request Dec 21, 2017

@adam3smith
Add Air University Journals (zotero#1494) 
* Add Air University

ASJP and SSQ -- lot's of scraping, and authors and abstract can be
inconsisten, but rest should be solid.
308df88

psisquared2 added a commit to psisquared2/translators that referenced this pull request Feb 8, 2018

@adam3smith @psisquared2
Add Air University Journals (zotero#1494) 
* Add Air University

ASJP and SSQ -- lot's of scraping, and authors and abstract can be
inconsisten, but rest should be solid.
3bf2f08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.