Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[EM] Don't concatenate different nodes by default #1595
Conversation
zuphilip
added
the
Workshop
label
Mar 17, 2018
zuphilip
force-pushed the
zuphilip:no-concatenate-em
branch
from
e991411
to
2afbf55
Sep 1, 2018
zuphilip
requested a review
from
adam3smith
Sep 1, 2018
zuphilip
added some commits
Mar 17, 2018
zuphilip
force-pushed the
zuphilip:no-concatenate-em
branch
from
2afbf55
to
2838e0f
Oct 7, 2018
This comment has been minimized.
This comment has been minimized.
|
@adam3smith Can you review these changes please? I have rebased this PR now and also fixed some unwanted consequences from the previous EM changes. |
adam3smith
reviewed
Oct 9, 2018
| @@ -1383,12 +1366,12 @@ var testCases = [ | |||
| } | |||
| ], | |||
| "date": "2013", | |||
| "abstractNote": "Signaling data from the cellular networks can provide a means of analyzing the efficiency of a deployed transportation system and assisting in the formulation of transport models to predict its fut ...", | |||
| "abstractNote": "DiVA portal is a finding tool for research publications and student theses written at the following 47 universities and research institutions.", | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
Oct 9, 2018
Collaborator
why is it picking up the site description from og:description rather than the abstract from DC.description? Since this is also true for the current EM translator, I'll accept this and create a new issue.
This comment has been minimized.
This comment has been minimized.
adam3smith
merged commit 3ebf896
into
zotero:master
Oct 9, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks, also for the EM fix, not sure why that didn't show up in testing for me. Only thing I've changed is to add a comment for the |
zuphilip
deleted the
zuphilip:no-concatenate-em
branch
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedMar 17, 2018
This lead to title and abstracts containing also a
translated form, see examples in Cairn.info.js.