Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Show error for new translators when license is bad #1650

Merged
merged 4 commits into from May 14, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Copy link
Collaborator

zuphilip commented May 10, 2018 •
edited

This would throw an error in cases like #1649. The commits here show a test of this CI test.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented May 14, 2018

Looks good to me, but haven't tested. Feel free to merge if you're happy with tests.
@zuphilip

zuphilip reviewed May 14, 2018
View changes

.ci/checkTranslator.sh
for t in "${newtranslators[@]}";do
if [ "$TRANSLATOR_BASENAME" == "$t" ];then
ERROR_CHECKS+=("badLicense")
unset WARN_CHECKS[0]

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip May 14, 2018

Author Collaborator

Note for future me: This only works as long as we don't change the order in this array.

@zuphilip zuphilip merged commit 7780c65 into zotero:master May 14, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:ci-agpl-check branch May 14, 2018

@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

zuphilip commented May 14, 2018

Thanks. I merged it; then we will see the results in practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.