Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upScienceDirect: fixes a buggy pdf query selector #1661
+2
−2
Conversation
zuphilip
merged commit 85ecb63
into
zotero:master
May 21, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
zuphilip
May 21, 2018
Collaborator
Thank you very much @adomasven!
BTW do you also see "error parsing XML" in Scaffold when running the automatic tests? Cf. zotero/scaffold#74
Thank you very much @adomasven! BTW do you also see "error parsing XML" in Scaffold when running the automatic tests? Cf. zotero/scaffold#74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
adomasven commentedMay 21, 2018
Report here https://forums.zotero.org/discussion/comment/307937/#Comment_307937
Safari seems to be served different content than other browsers and the conditional branch on that different content had a buggy query selector.