Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate BibLaTeX translator - nodate, notitle, noauthor #1671
Conversation
zuphilip
reviewed
Jun 4, 2018
Looks good for me and is in line with https://github.com/zotero/translators/pull/1243/files . But you need to change the lastUpdated value as well, otherwise the change will not distributed to the users.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@zuphilip I changed the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam-ah
Jun 6, 2018
@mhellmeier If you are working on the BibLaTex export anyway, would you mind incorporating these changes too? :)
#1667
I've attached a diff so not much actual work to do, I just don't want to go through the PR process
adam-ah
commented
Jun 6, 2018
|
@mhellmeier If you are working on the BibLaTex export anyway, would you mind incorporating these changes too? :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 7, 2018
Collaborator
@mhellmeier Okay, thank you. This looks fine for me and ready to merge.
@adam-ho We can deal with this issue separately. I just need a little more time to look into this.
@adam3smith I will wait some days before merging to give you some time to look into this change of the citekey in BibLaTeX translator. But it should just do the same as we already have for the BibTeX translator.
|
@mhellmeier Okay, thank you. This looks fine for me and ready to merge. @adam-ho We can deal with this issue separately. I just need a little more time to look into this. @adam3smith I will wait some days before merging to give you some time to look into this change of the citekey in BibLaTeX translator. But it should just do the same as we already have for the BibTeX translator. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Jun 7, 2018
Collaborator
|
Haven't looked at code, but mirroring bibtex citekey behavior sounds right,
so OK to merge
…Sent from my phone
On Thu, Jun 7, 2018, 01:09 Philipp Zumstein ***@***.***> wrote:
@mhellmeier <https://github.com/mhellmeier> Okay, thank you. This looks
fine for me and ready to merge.
@adam-ho <https://github.com/adam-ho> We can deal with this issue
separately. I just need a little more time to look into this.
@adam3smith <https://github.com/adam3smith> I will wait some days before
merging to give you some time to look into this change of the citekey in
BibLaTeX translator. But it should just do the same as we already have for
the BibTeX translator.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1671 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH32tMqag_guIk_ZtcBaprptXF9e-_zks5t6LWBgaJpZM4UYRWz>
.
|
zuphilip
merged commit f3b2bd0
into
zotero:master
Jun 7, 2018
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@mhellmeier Thank you! |
mhellmeier commentedJun 3, 2018
BibLaTeX exports a missing date with question marks, BibTeX exports a missing date with nodate
I changed the BibLaTeX translator to the same strings as the BibTeX translator.
My original problem is described here: https://forums.zotero.org/discussion/comment/309794