Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWHO translator and fixing nits in Copernicus translator #1731
Conversation
mtrojan-ub
and others
added some commits
Mar 15, 2018
This comment has been minimized.
This comment has been minimized.
adam3smith
reviewed
Sep 2, 2018
WHO.js
Outdated
| // copy meta tags in body to head | ||
| var head = doc.getElementsByTagName('head'); | ||
| var metasInBody = ZU.xpath(doc, '//body/meta'); | ||
| for (let i=0; i<metasInBody.length; i++) { |
This comment has been minimized.
This comment has been minimized.
adam3smith
Sep 2, 2018
Collaborator
FWIW, I think Zotero house style now prefers for (let item of array) to cycle through arrays unless you need the index. I'll change that here, but I don't think it's worth it going through translators since there's no effective difference.
This comment has been minimized.
This comment has been minimized.
|
@zuphilip see what you think of my edit. Otherwise good to merge. |
This comment has been minimized.
This comment has been minimized.
|
Thank you! These are good improvements. I tried to clarify the comment and am otherwise happy with this. |
zuphilip
merged commit 803f04c
into
zotero:master
Sep 2, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
zuphilip
deleted the
zuphilip:mtrojan-who
branch
Sep 2, 2018
This comment has been minimized.
This comment has been minimized.
|
Thank you @mtrojan-ub for starting with this work! |
zuphilip
referenced this pull request
Sep 2, 2018
Closed
Copernicus improvements + basic WHO translator #1593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedSep 2, 2018
I cherry-picked from the commits by @mtrojan-ub, rebased them and rewrote the WHO translator.
This superseeds #1593.