Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadjust export button xpath #1733
Conversation
adam3smith
added some commits
Sep 2, 2018
adam3smith
requested a review
from
zuphilip
Sep 4, 2018
This comment has been minimized.
This comment has been minimized.
|
well, still in my master branch, but oh well. |
ScienceDirect.js
Outdated
| @@ -28,7 +28,7 @@ function detectWeb(doc, url) { | |||
| if ((url.includes("pdf") && | |||
| !url.includes("_ob=ArticleURL") && | |||
| !url.includes("/article/")) || | |||
| url.search(/\/(?:journal|bookseries|book|handbooks|referenceworks)\//) !== -1) { | |||
| url.search(/\/(?:journal|bookseries|book|handbook|referenceworks)\//) !== -1) { | |||
This comment has been minimized.
This comment has been minimized.
zuphilip
Sep 4, 2018
Collaborator
What about the referenceworks? You delete the example below and I guess they don't work the same as the other multiples, right? If so, then we should delete it here.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think I addressed everything. Please take another look when you get a chance |
zuphilip
approved these changes
Sep 8, 2018
zuphilip
merged commit 577948f
into
zotero:master
Sep 8, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thank you @adam3smith ! You might want to clean your master branch now after the squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adam3smith commentedSep 4, 2018
remove/change some tests