Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow unused "detectImport" #1916
Conversation
retorquere
added some commits
Mar 28, 2019
This comment has been minimized.
This comment has been minimized.
|
OK, fixed. |
dstillman
reviewed
Mar 29, 2019
This comment has been minimized.
This comment has been minimized.
|
But I'm not clear what this is actually doing. Can you explain? |
This comment has been minimized.
This comment has been minimized.
|
It checks consistency of what a translator declared it will do by its translatortype, and what it actually does in terms of handlers. |
retorquere
added some commits
Mar 31, 2019
dstillman
merged commit a6a8426
into
zotero:master
Apr 1, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
retorquere
deleted the
retorquere:patch-1
branch
Apr 1, 2019
adam3smith
added a commit
that referenced
this pull request
Apr 1, 2019
dstillman
added a commit
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
retorquere commentedMar 28, 2019
•
edited
no-unused-varsalso applies to functions and therefore reports (detect|do)(Export|Web|Import) as problems, because they're not called within the body of the translator. Also, I misnameddetectImportasdoDetect.