Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create uclouvain-faculte-de-droit.csl #3984

Merged
merged 7 commits into from Mar 25, 2019

Conversation

Projects
None yet
3 participants
@anfourny
Copy link
Contributor

anfourny commented Mar 12, 2019

J'ai créé ce style pour correspondre au mode de citation de notre faculté au sein de l'UCLouvain.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 12, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 12, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 12, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 12, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 24, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 24, 2019

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

adam3smith left a comment

A couple of remaining questions. Looks good otherwise.

<id>http://www.zotero.org/styles/uclouvain-faculte-de-droit</id>
<link href="http://www.zotero.org/styles/uclouvain-faculte-de-droit" rel="self"/>
<link href="http://www.zotero.org/styles/european-journal-of-international-law" rel="template"/>
<link href="https://drive.google.com/open?id=15OM1dTvZVOMQNg_0DyvwFRRw9M3idV3E" rel="documentation"/>

This comment has been minimized.

@adam3smith

adam3smith Mar 24, 2019

Member

If you have any ability to influence that, a version of the style at a slightly more official location would be great.

</name>
<substitute>
<names variable="editor">
<name and="text" delimiter-precedes-last="never" et-al-min="4" et-al-use-first="1" initialize="false" initialize-with=". " sort-separator=" ">

This comment has been minimized.

@adam3smith

adam3smith Mar 24, 2019

Member

are the et al settings (and other name parameters) really different for editors?

<else-if type="thesis" match="any">
<group delimiter=", ">
<text macro="author-bibliography" suffix=", "/>
<text variable="title" text-case="title" prefix="'" suffix="' "/>

This comment has been minimized.

@adam3smith

adam3smith Mar 24, 2019

Member

are these single quotes really right? THat seems odd.

Update uclouvain-faculte-de-droit.csl
Thanks very much for your comments. I have made the changes accordingly. Hope these are ok now :)
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 25, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 25, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 5e6ff65 into citation-style-language:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Mar 25, 2019

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.