Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update council-of-science-editors.csl to 8th edition #2829

Merged
merged 2 commits into from Jul 20, 2017

Conversation

Projects
None yet
3 participants
@POBrien333
Copy link
Contributor

POBrien333 commented Jul 19, 2017

via https://forums.zotero.org/discussion/comment/267127/#Comment_267127
and #2749
Added the doi bit.
It already had the URL and [accessed] bit.

alphabetical style dealt with here: #2830

Update council-of-science-editors.csl
via https://forums.zotero.org/discussion/comment/267127/#Comment_267127
and #2749
Added the doi bit.
It already had the URL and [accessed] bit.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 19, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 19, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 20, 2017

@POBrien333, there is no real need for a DOI macro here, since it's just a one-liner, and part of the prefix (". " in prefix=". doi:") belongs outside the macro anyways.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 20, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 20, 2017

(and can you take a look at https://github.com/citation-style-language/styles/blob/master/council-of-science-editors-alphabetical.csl as well? Per #2749 (comment), it is currently definitely wrong, since a journal article should always print the journal ("container-title"))

@rmzelle rmzelle merged commit 95a681e into citation-style-language:master Jul 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jul 20, 2017

Thanks!

@POBrien333 POBrien333 changed the title Update council-of-science-editors.csl Update council-of-science-editors.csl to 8th edition Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.