Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update international-journal-of-geriatric-psychiatry.csl #3140

Merged
merged 2 commits into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@POBrien333
Copy link
Contributor

POBrien333 commented Nov 26, 2017

Found a whole bunch of mistakes just by random. Should be a bit better now.

Update international-journal-of-geriatric-psychiatry.csl
Found a whole bunch of mistakes just by random. Should be a bit better now.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 26, 2017

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 26, 2017

😃 Your submission passed all our automated tests.

@@ -45,6 +45,7 @@
<macro name="author-short">
<names variable="author">
<name form="short" and="text" delimiter=", " delimiter-precedes-last="never" initialize-with=". "/>
<et-al/>

This comment has been minimized.

@adam3smith

adam3smith Nov 26, 2017

Member

why are you adding this? This shouldn't change anything.

This comment has been minimized.

@POBrien333

POBrien333 Nov 28, 2017

Author Contributor

Not sure where that is coming from. thanks for spotting it.

@adam3smith
Copy link
Member

adam3smith left a comment

Found some more small bits. Thanks!

@@ -20,7 +19,7 @@
<issn>0885-6230</issn>
<eissn>1099-1166</eissn>
<summary>Harvard (author-date style) for International Journal of Geriatric Psychiatry</summary>

This comment has been minimized.

@adam3smith

adam3smith Nov 26, 2017

Member

we should add a note that this follows published articles and not the (useless) author guidelines

@@ -160,7 +159,7 @@
</group>
</layout>
</citation>
<bibliography>
<bibliography delimiter-precedes-et-al="always" et-al-min="4" et-al-use-first="3">

This comment has been minimized.

@adam3smith

adam3smith Nov 26, 2017

Member

I think this is 6/3 or 7/3 I see at least 5 listed authors here: http://onlinelibrary.wiley.com/doi/10.1002/gps.4447/epdf I think 7/3 is the most common rule, so I'd go with that.

@@ -146,7 +145,7 @@
</if>
</choose>
</macro>
<citation et-al-min="4" et-al-use-first="1" disambiguate-add-year-suffix="true" disambiguate-add-names="true" disambiguate-add-givenname="true" collapse="year">
<citation delimiter-precedes-et-al="never" et-al-min="4" et-al-use-first="1" disambiguate-add-names="true" disambiguate-add-givenname="true" disambiguate-add-year-suffix="true" collapse="year">

This comment has been minimized.

@adam3smith

adam3smith Nov 26, 2017

Member

Looking at the Crellin et al. reference in http://onlinelibrary.wiley.com/doi/10.1002/gps.4447/epdf I think this should be 3/1

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Nov 28, 2017

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit f1e9a0f into citation-style-language:master Nov 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Nov 29, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.