Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create johnson-matthey-technology-review.csl #3319

Merged
merged 4 commits into from Aug 6, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@coless82 @csl-bot @POBrien333 @rmzelle @adam3smith
@coless82
Copy link
Contributor

coless82 commented Feb 8, 2018

I hope someone can help perfect this style, we are not expert coders.
The problems that we have are as follows:

Patents (Ref. 12 in the Mendeley example set)
Need to get the word into italics and if possible, set up rules to specify if US, World, etc. and if Patent or Application, depending on the code.

Patents (Ref. 12 in the example set)
Add assignees' details: inventor name(s), institution or company name

Examples:
H. Van Den Elzen, World Appl. 2011/129,992
also:
R. L. Pruett and J. A. Smith, Union Carbide Corporation, ‘Hydroformylation Process’, US Patent 3,527,809; 1970

Content types - report, thesis, book, chapter. (References 2, 3, 5, 8-11):
How to add the country to the publisher place?

Reference 14: Webpage references
There is an extra space before the colon, we need to remove this extra space.

Dates with day and month - content types article-newspaper, webpage (References 7, 14)
We would like if possible a suffix on the day i.e. "st" for "1st, 21st," etc. and "nd" for "2nd, 22nd", etc and "rd" for "3rd, 23rd", "th" for "4th, 24th" etc. Is it possible?

Dates with day and month
Also we would like a comma between the month and the year, if possible to do so, as:
15th April, 2015

Journal article (ref. 1)
“et al.” appears after 100 author names in journal article whereas we do not want to use "et al" at all, can it be removed?
@coless82
Create johnson-matthey-technology-review.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
870604d
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Feb 8, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Feb 8, 2018

😟 There are some issues with your submission. Please check the test report for details.

coless82 referenced this pull request Feb 8, 2018

@coless82
Merge 870604d into 65cecb7
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
25a876e
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Feb 8, 2018

Can you run your style through the formatter and then edit the PR here? currently it's all in one line. http://formatter.citationstyles.org/
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Feb 8, 2018

Sorry about that. I thought I had done so. I was using IE - I just retried the formatter using Chrome and that seems to work better. How do I reupload the corrected file?

Regards
Sara
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Feb 8, 2018

The first comment you got on this pull request (#3319 (comment)) describes how to update your submission.
@coless82
Update johnson-matthey-technology-review.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
832243e
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Feb 8, 2018

Thanks I have done that now.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Feb 8, 2018

😟 There are some issues with your submission. Please check the test report for details.
@adam3smith
Some clean-up; hopefully some patent improvements
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c85b92c
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Feb 18, 2018

😟 There are some issues with your submission. Please check the test report for details.
@adam3smith
Fix tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9af1372
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Feb 18, 2018

😃 Your submission passed all our automated tests.
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Mar 21, 2018

Hi, we'd like to start using the style for our authors in Mendeley, Zotero, etc. As this has now passed the tests is it ready? What do I need to do next? Thanks!
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Mar 22, 2018

Hi, The style seems to be fixed, can anyone help me to get this approved? Does it need to be merged and who can help with this please? Many thanks.
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Mar 23, 2018

@coless82
Hi,
One of the 2 people who reviews the styles here is currently not as active.
@adam3smith might be able to help, but you can always just upload the .csl file onto your website and insert the link in your author guidelines, so your authors can access the style already.
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Apr 19, 2018

Thanks @adam3smith and @POBrien333 . We have for now uploaded to our website as .txt file and added it to our Information for Authors.

https://www.technology.matthey.com/for-authors/#references
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Apr 24, 2018 •
edited

@coless82
I think it makes more sense to give the file as a .csl and not .txt. also you got all the + in each line.
You can literally use this link here: https://raw.githubusercontent.com/coless82/styles/9af13728ea04e913b95b4322aea98c8385b792da/johnson-matthey-technology-review.csl

@rmzelle
Any chance we can get this one reviewed and merged? :)
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Apr 30, 2018

Thanks @POBrien333 and @rmzelle for your help so far! We have updated the link on our website.

@rmzelle rmzelle merged commit acfbc30 into citation-style-language:master Aug 6, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented Aug 6, 2018 •
edited

Thanks! @coless82, sorry for letting this sit for so long. I just merged the style into the repository, and it should show up for Zotero and Mendeley users within the next 24 hours.
@coless82

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

coless82 commented Aug 6, 2018

Thanks very much @rmzelle and everyone who's helped us with this.
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor

POBrien333 commented Aug 6, 2018

You can now also use this link to link to the latest style: https://www.zotero.org/styles?q=id%3Ajohnson-matthey-technology-review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.