Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create international-biodeterioration-and-biodegradation.csl #3654

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@POBrien333
Copy link
Contributor

POBrien333 commented Aug 22, 2018

via https://forums.zotero.org/discussion/73104/question-about-style-international-biodeterioration-biodegradation

Made independent style with sorting adapted as per guidelines (via editors).

Added dependent style to skip list: citation-style-language/journals#70

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 22, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 22, 2018

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Aug 22, 2018

(you still need to delete the dependent style)

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Aug 22, 2018

Is that not deleted automatically when the PR for addition to the skip list get's signed off?

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Aug 22, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Aug 22, 2018

no. We'd have to then re-run the generate dependent script and make a separate PR for its outcome (which is also just to delete that one file), which takes longer than fixing this here.

@adam3smith adam3smith merged commit e1f359a into citation-style-language:master Aug 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Aug 22, 2018

thanks!

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Aug 22, 2018

ah ok. Understood. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.