Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upinclude Patents #3757
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 24, 2018
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 24, 2018
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 25, 2018
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, can you take a look? The whole (PR didn't validate because of |
This comment has been minimized.
This comment has been minimized.
I'm fine with that conditional. Sure, you could do this with a group, but that saves one or two lines. The rest looks good. DIN patent citations are weird... I'm not sure how to even make sense of them in the other DIN styles so I'd leave it at this one. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Oct 28, 2018
|
adam3smith
merged commit 0e04b35
into
citation-style-language:master
Oct 29, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
joka-de commentedOct 24, 2018
added a section for somewhat proper inclusion of patents in citations