Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diabetologia.csl #3913

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@POBrien333
Copy link
Contributor

POBrien333 commented Feb 6, 2019

Make independent style.
via https://forums.zotero.org/discussion/75482/diabetologia-style-needs-updating
Only changes is the et-al settings and that it wants the issue number of a article-journal.

Free publication from 2019: https://link.springer.com/content/pdf/10.1007%2Fs00125-018-4775-z.pdf

Update diabetologia.csl
Make independent style.
via https://forums.zotero.org/discussion/75482/diabetologia-style-needs-updating#latest
Only changes is the et-al settings and that it wants the issue number of a article-journal.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 6, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 6, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 6, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 8, 2019

Let's wait with this until we're certain this just affects Diabetologia, which might not be the case (per https://forums.zotero.org/discussion/comment/325921/#Comment_325921).

@rmzelle rmzelle merged commit 657ca40 into citation-style-language:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 8, 2019

Thanks. Looks like they just confirmed on the Zotero forums that this needs to be a custom style.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 8, 2019

(still need to put this on the skip list for the Springer journals metadata)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.