Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeitgeschichte-wien-german #3987

Merged
merged 8 commits into from Mar 23, 2019
+393 −0

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MertzG @csl-bot @adam3smith
@MertzG
Copy link
Contributor

MertzG commented Mar 14, 2019

No description provided.

@MertzG
Zeitschrift Zeitgeschichte Wien (German)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
56858ca
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 14, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 14, 2019

😟 There are some issues with your submission. Please check the test report for details.
@MertzG
Rename zeitgeschichte-wien-german to zeitgeschichte-wien-german.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7747fa6
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 14, 2019

😟 There are some issues with your submission. Please check the test report for details.

@MertzG MertzG changed the title Zeitschrift Zeitgeschichte Wien (German) zeitgeschichte-wien-german Mar 14, 2019

@MertzG
Update zeitgeschichte-wien-german.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2e74a59
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 14, 2019

😃 Your submission passed all our automated tests.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Mar 16, 2019

Thanks! This looks like it is based on an existing style. Do you remember which?
@MertzG

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

MertzG commented Mar 16, 2019

Sorry I don't know anymore. Is there a way to find out?
@MertzG
Update zeitgeschichte-wien-german.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3d7d812
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 16, 2019

😟 There are some issues with your submission. Please check the test report for details.
@MertzG
Update zeitgeschichte-wien-german.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c263347
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 16, 2019

😃 Your submission passed all our automated tests.
@adam3smith
Some clean-up
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac79608
@adam3smith

adam3smith reviewed Mar 18, 2019
View changes

Copy link
Member

adam3smith left a comment

Thanks. Looking pretty good. I still have a couple of questions. I'm pretty sure I was able to identify the style you started from. Please do keep track of that if you are going to submit further styles.
zeitgeschichte-wien.csl Outdated
<text prefix=", " macro="pages"/>
<choose>
<if variable="page" type="chapter" match="all">
<text prefix=", hier " macro="citation-locator"/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Mar 18, 2019

Member

I'm not seeing the ", hier" for indidividual pages in the journal. Are you sure that's correct?
zeitgeschichte-wien.csl Outdated
<macro name="citation-locator">
<text variable="locator"/>
</macro>
<citation et-al-subsequent-min="6" et-al-subsequent-use-first="5" disambiguate-add-names="true">

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Mar 18, 2019

Member

I don't see any mention of the et-al settings in the guide. You're sure about those?
zeitgeschichte-wien.csl Outdated
<style class="note" version="1.0" names-delimiter="/" demote-non-dropping-particle="sort-only" default-locale="de-DE" xmlns="http://purl.org/net/xbiblio/csl">
<!-- This style was edited with the Visual CSL Editor (http://editor.citationstyles.org/visualEditor/) -->
<info>
<title>Zeitgeschichte Wien (German)</title>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Mar 18, 2019

Member

I'm seeing the journal listed as "Zeitgeschichte" everywhere. Why add the "Wien" part?
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 18, 2019

😃 Your submission passed all our automated tests.
@MertzG

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

MertzG commented Mar 18, 2019 •
edited

Thank you for checking in detail. You are right with all three points: "Wien" can be left out. I checked back with the lecturer of Zeitgeschichte and "hier" can be left in but must not.
@MertzG
Update zeitgeschichte-wien.csl 
fixed, et-al, "hier" and "Wien"
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d79774f
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 18, 2019

😟 There are some issues with your submission. Please check the test report for details.
@MertzG
Rename zeitgeschichte-wien.csl to zeitgeschichte.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04e5a42
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Mar 18, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 871eb73 into citation-style-language:master Mar 23, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Mar 23, 2019

Great, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.