Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upzeitgeschichte-wien-german #3987
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 14, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 14, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 14, 2019
|
MertzG
changed the title
Zeitschrift Zeitgeschichte Wien (German)
zeitgeschichte-wien-german
Mar 14, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 14, 2019
|
This comment has been minimized.
This comment has been minimized.
Thanks! This looks like it is based on an existing style. Do you remember which? |
This comment has been minimized.
This comment has been minimized.
Sorry I don't know anymore. Is there a way to find out? |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 16, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 16, 2019
|
adam3smith
reviewed
Mar 18, 2019
Thanks. Looking pretty good. I still have a couple of questions. I'm pretty sure I was able to identify the style you started from. Please do keep track of that if you are going to submit further styles. |
<text prefix=", " macro="pages"/> | ||
<choose> | ||
<if variable="page" type="chapter" match="all"> | ||
<text prefix=", hier " macro="citation-locator"/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 18, 2019
Member
I'm not seeing the ", hier" for indidividual pages in the journal. Are you sure that's correct?
<macro name="citation-locator"> | ||
<text variable="locator"/> | ||
</macro> | ||
<citation et-al-subsequent-min="6" et-al-subsequent-use-first="5" disambiguate-add-names="true"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 18, 2019
Member
I don't see any mention of the et-al settings in the guide. You're sure about those?
<style class="note" version="1.0" names-delimiter="/" demote-non-dropping-particle="sort-only" default-locale="de-DE" xmlns="http://purl.org/net/xbiblio/csl"> | ||
<!-- This style was edited with the Visual CSL Editor (http://editor.citationstyles.org/visualEditor/) --> | ||
<info> | ||
<title>Zeitgeschichte Wien (German)</title> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Mar 18, 2019
Member
I'm seeing the journal listed as "Zeitgeschichte" everywhere. Why add the "Wien" part?
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 18, 2019
|
This comment has been minimized.
This comment has been minimized.
Thank you for checking in detail. You are right with all three points: "Wien" can be left out. I checked back with the lecturer of Zeitgeschichte and "hier" can be left in but must not. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 18, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 18, 2019
|
adam3smith
merged commit 871eb73
into
citation-style-language:master
Mar 23, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Great, thanks! |
MertzG commentedMar 14, 2019
No description provided.