Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[js] Upgrade babel-eslint to version 10.0.1 #231
Conversation
depfu
bot
added
the
depfu
label
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 11, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 35 35
Lines 533 533
=======================================
Hits 493 493
Misses 40 40Continue to review full report at Codecov.
|
depfu
bot
force-pushed the
depfu/update/npm/babel-eslint-10.0.1
branch
from
34f2bed
to
dd41d37
Dec 12, 2018
This comment has been minimized.
This comment has been minimized.
|
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/npm/babel-eslint-10.0.1
branch
from
dd41d37
to
71d6bb2
Dec 12, 2018
ruebot
merged commit 7fd9117
into
master
Dec 12, 2018
depfu
bot
deleted the
depfu/update/npm/babel-eslint-10.0.1
branch
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedDec 11, 2018
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
10.0.1
v10.0.1
The
TypeAlias"conversion" to a function has issues. Sounds like we need to rethink the change, most likely we can just actually change the scoping rather than hardcode an AST change.Commits
See the full diff on Github. The new version differs by 2 commits:
10.0.1Revert #584 (#697)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands