New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Policy, Resolves Issue #181 #237

Merged
merged 4 commits into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@SamFritz
Member

SamFritz commented Dec 21, 2018

GitHub issue(s):

This pull request addresses the implementation of a privacy policy for the Archives Unleashed Project, including the Cloud and all related domains. This privacy policy will be house both on the Cloud website and on the main project website.

The full issue and subsequent discussion can be found on issue 181

What does this Pull Request do?

The privacy policy outlines all information practices of Archives Unleashed and will be housed on a static page and linked in the footer.

The commits also adjust css file to deal with ul/li

Additional Notes:

The privacy policy will also live on the archivesunleashed.org website and is detailed in the archivesunleashed.org repo issue #82

Interested parties

@ianmilligan1 @ruebot thanks for you help with review of content.

ruebot and others added some commits Dec 20, 2018

Setup Privacy Policy stub.
- Add Privacy Policy page
- Update routes
- Create test
- Update footer

@SamFritz SamFritz added the copy label Dec 21, 2018

@SamFritz SamFritz self-assigned this Dec 21, 2018

@SamFritz SamFritz requested review from ruebot and ianmilligan1 Dec 21, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Dec 21, 2018

Codecov Report

Merging #237 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   92.49%   92.55%   +0.05%     
==========================================
  Files          35       35              
  Lines         533      537       +4     
==========================================
+ Hits          493      497       +4     
  Misses         40       40
Impacted Files Coverage Δ
test/controllers/pages_controller_test.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c547c...a5d3c49. Read the comment docs.

@ruebot

Small change.

<td class="auk_deriv_td_table">Yes</td>
<td class="auk_deriv_td_table">No</td>
<td class="auk_deriv_td_table">
<p class="about_p">Your Github/Twitter user name and password are only used to authenticate. We don't have access to nor collect this information.</p></td>

This comment has been minimized.

@ruebot

ruebot Dec 21, 2018

Member

s/user name/username/

This comment has been minimized.

@ruebot

ruebot Dec 21, 2018

Member

Also, sorry, I should have caught this in the Google doc:

Your Github/Twitter user name and password are only used to authenticate. We don't have access to nor collect this information.

We do store the username, that's it. No password or anything else.

@ianmilligan1

Few minor changes but then looks good to me!

<div class="auk_deriv_accord card">
<div class="auk_deriv_accord-header card-header" id="headingOne">
<h5 class="mb-0">
<button class="btn btn-link" data-toggle="collapse" data-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne">-- Personal Data</button>

This comment has been minimized.

@ianmilligan1

ianmilligan1 Dec 21, 2018

Member

-- Personal Data
->
Personal Data

(we don't need the leading -- in the accordion headers)

<% cache do %>
<div class="container">
<h1 class=about_h1>The Archives Unleashed Privacy Policy </h1>
<p class="about_p">We recognize the importance of and are committed to protecting the privacy of all users. The following privacy policy guides and outlines the Archives Unleashed Project’s online information practices.</p>

This comment has been minimized.

@ianmilligan1

ianmilligan1 Dec 21, 2018

Member

... the Archives Unleashed Project's (AU) online information practices.

We use AU as a general acronym later so best to define it here.

<div class="auk_deriv_accord card" id="accordion">
<div class="auk_deriv_accord-header card-header" id="headingTwo">
<h5 class="mb-0">
<button class="btn btn-link collapsed" data-toggle="collapse" data-target="#collapseTwo" aria-expanded="false" aria-controls="collapseTwo">-- Usage Data</button>

This comment has been minimized.

@ianmilligan1

ianmilligan1 Dec 21, 2018

Member

Same as above

-- Usage Data

remove the --

<div class="auk_deriv_accord card" id="accordion">
<div class="auk_deriv_accord-header card-header" id="headingThree">
<h5 class="mb-0">
<button class="btn btn-link collapsed" data-toggle="collapse" data-target="#collapseThree" aria-expanded="false" aria-controls="collapseThree">-- Tracking & Cookies Data</button>

This comment has been minimized.

@ianmilligan1

ianmilligan1 Dec 21, 2018

Member

And same here, let's remove -- before Tracking & Cookies Data

<p class="about_p"><strong>Changes to this Privacy Policy</strong></p>
<p class="about_p">Any updates to our Privacy Policy will be posted to this page. We will also let users know via email and/or a prominent notice, prior to the change becoming effective and update the "effective date" at the top of this Privacy Policy. Changes to this Privacy Policy are effective when they are posted on this page.</p>
<p class="about_p"><strong>Contact Us</strong></p>
<p class="about_p">General questions or concerns about the Archives Unleashed Privacy Policy should be directed to our Project Manager, <%= link_to('Samantha Fritz','mailton:sam.fritz@archivesunleashed.org', target: '_blank') %></p>

This comment has been minimized.

@ianmilligan1

ianmilligan1 Dec 21, 2018

Member

add a period after Samantha Fritz link

@ruebot

ruebot approved these changes Dec 21, 2018

@ruebot ruebot merged commit c70a336 into master Dec 21, 2018

3 checks passed

codecov/patch 100% of diff hit (target 92.49%)
Details
codecov/project 92.55% (+0.05%) compared to d7c547c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the issue-181 branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment