/auk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for display_domains and filtered text path helpers. #254

Merged
merged 1 commit into from Jan 24, 2019
+959 −16

Conversation

Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @codecov-io @ianmilligan1
@ruebot
Copy link
Member

ruebot commented Jan 24, 2019

  • Resolves #158
  • Add fixture to test display_domains helper
  • Update existing tests for updated fixture setup
  • Update fixture yamls to reflect updated fixture assets

Here we go again creating more tests.
@ruebot
Add test coverage for display_domains and filtered text path helpers. 
- Resolves #158
- Add fixture to test display_domains helper
- Update existing tests for updated fixture setup
- Update fixture yamls to reflect updated fixture assets
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
3d0f469
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Jan 24, 2019 •
edited

Codecov Report

Merging #254 into master will increase coverage by 1.87%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   94.49%   96.37%   +1.87%     
==========================================
  Files          35       35              
  Lines         545      551       +6     
==========================================
+ Hits          515      531      +16     
+ Misses         30       20      -10
Impacted Files Coverage Δ
test/helpers/application_helper_test.rb 100% <100%> (ø) ⬆️
test/helpers/wasapi_files_helper_test.rb 100% <100%> (ø) ⬆️
test/helpers/collections_helper_test.rb 100% <100%> (ø) ⬆️
test/helpers/dashboards_helper_test.rb 100% <100%> (ø) ⬆️
app/helpers/collections_helper.rb 100% <0%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b03fa...3d0f469. Read the comment docs.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member

ruebot commented Jan 24, 2019

@ianmilligan1 here's another 😄
@ianmilligan1

ianmilligan1 approved these changes Jan 24, 2019
View changes

@ianmilligan1 ianmilligan1 merged commit eb39de9 into archivesunleashed:master Jan 24, 2019
3 checks passed

3 checks passed

codecov/patch 100% of diff hit (target 94.49%)
Details
codecov/project 96.37% (+1.87%) compared to 28b03fa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment