/graphpass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XML 1.0; resolves #26. #41

Merged
merged 1 commit into from Aug 28, 2018
+72 −72

Conversation

Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
@ruebot
Member

ruebot commented Aug 28, 2018

  • Roll back to XML 1.0 from 1.1 introduced in
    d17b57c
  • Roll back to Gexf 1.2 from 1.3 introduced in
    d17b57c
  • Switch line ending encoding from \n to \x0A
  • Clean up whitespace in file

#27 was being weird.
@ruebot
Use XML 1.0; resolves #26. 
- Roll back to XML 1.0 from 1.1 introduced in
d17b57c
- Roll back to Gexf 1.2 from 1.3 introduced in
d17b57c
- Switch line ending encoding from \n to \x0A
- Clean up whitespace in file
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
a1e5f3f
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Aug 28, 2018

Member

@greebie @ianmilligan1 this will need a re-test when y'all have time.
Member

ruebot commented Aug 28, 2018

@greebie @ianmilligan1 this will need a re-test when y'all have time.

@ruebot ruebot referenced this pull request Aug 28, 2018

Closed

Remove commented out gexf code; resolves #28. #39

@ianmilligan1

ianmilligan1 approved these changes Aug 28, 2018
View changes

Tested and works in AUK:
screen shot 2018-08-28 at 9 42 21 am

And Gephi:
screen shot 2018-08-28 at 9 42 13 am

@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Aug 28, 2018

Collaborator

Works great on my end. Thanks @ruebot !
Collaborator

greebie commented Aug 28, 2018

Works great on my end. Thanks @ruebot !

@greebie greebie merged commit d03c01a into archivesunleashed:master Aug 28, 2018

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Aug 28, 2018

Member

Cool. I'll build this on the auk production server, and get it into production.
Member

ruebot commented Aug 28, 2018

Cool. I'll build this on the auk production server, and get it into production.

@ruebot ruebot deleted the ruebot:issue-26 branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment