/graphpass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up and organize project; resolves #40. #50

Merged
merged 2 commits into from Sep 4, 2018
+1,224 −1,401

Conversation

Reviewers

@greebie greebie

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
@ruebot
Member

ruebot commented Sep 3, 2018

GitHub issue(s): #40

What does this Pull Request do?

  • Moves Docs -> doc
  • Moves tests -> src/tests
  • Moves headers -> src/headers
  • Moves src/*.c -> src/main
  • Moves unity -> vendor/unity
  • Updates Doxygen config
  • Update Doxygen generated docs
  • Update README
  • Update all src files that need to be updated to reflect re-org
  • Update Makefile so project builds
  • Clean-up whitespace in src files
  • Simplify Makefile

How should this be tested?

It should build, test should pass, and it should still run as it currently does. I've built, and test it with auk locally, and everything appears to be working fine.

Additional Notes:

  • I created #49 for the automake support, and the branch for it is here branch is here.

  • doxygen version number dropping shouldn't be a problem. It's what was available in apt for Ubuntu 18.04.
@ruebot
Clean-up and organize project; resolves #40. 
- Moves Docs -> doc
- Moves tests -> src/tests
- Moves headers -> src/headers
- Moves src/*.c -> src/main
- Moves unity -> vendor/unity
- Updates Doxygen config
- Update Doxygen generated docs
- Update README
- Update all src files that need to be updated to reflect re-org
- Update Makefile so project builds
- Clean-up whitespace in src files
- Simplify Makefile
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
8bd99a1

@ruebot ruebot requested review from greebie and ianmilligan1 Sep 3, 2018

@ianmilligan1

ianmilligan1 approved these changes Sep 3, 2018
View changes

Builds fine and tested on sample files (using the -q and -g flags).

@ruebot ruebot referenced this pull request Sep 3, 2018

Closed

License header in src/ are inconsistent #51

@greebie

greebie approved these changes Sep 4, 2018
View changes

@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Sep 4, 2018

Collaborator

Thanks for this Nick. Great clean up job.
Collaborator

greebie commented Sep 4, 2018

Thanks for this Nick. Great clean up job.
@ianmilligan1
Merge branch 'master' into issue-40
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f707dfe

@ruebot ruebot referenced this pull request Sep 4, 2018

Closed

Doxyfile points to absolute rather than relative directory #54

@greebie greebie merged commit 3a99b92 into master Sep 4, 2018

@ruebot ruebot deleted the issue-40 branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment