/graphpass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize license headers; resolves #51. #57

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Reviewers

@greebie greebie

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
@ruebot
Member

ruebot commented Sep 5, 2018

GitHub issue(s): #51

What does this Pull Request do?

  • Update license header in all src files.
  • Update README
  • Rename LICENSE.txt to LICENSE
  • Make LICENSE consistent with other AU projects

How should this be tested?

TravisCI should take care of it.

Additional Notes:

Updated version of #56
@ruebot
Normalize license headers; resolves #51. 
- Update license header in all src files.
- Update README
- Rename LICENSE.txt to LICENSE
- Make LICENSE consistent with other AU projects
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
6ff5b25

@ruebot ruebot requested review from greebie and ianmilligan1 Sep 5, 2018

@ruebot
Merge branch 'master' into issue-51
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f0d0252
@ianmilligan1

ianmilligan1 approved these changes Sep 5, 2018
View changes

Looks great to me (and 🎉 on the TravisCI).

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 5, 2018

Member

Huh. CodeCov is still being wonky.
Member

ruebot commented Sep 5, 2018

Huh. CodeCov is still being wonky.
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 5, 2018

Member

Oh, duh. We're not producing any type of coverage report for CodeCov to look at. 🤦‍♂️

I'll create a ticket for that.
Member

ruebot commented Sep 5, 2018

Oh, duh. We're not producing any type of coverage report for CodeCov to look at. 🤦‍♂️

I'll create a ticket for that.
@greebie

This comment has been minimized.

Show comment
Hide comment
@greebie

greebie Sep 5, 2018

Collaborator

This lgtm. @ruebot the codecov issue is separate from this PR right? I can merge now I'm happy?
Collaborator

greebie commented Sep 5, 2018

This lgtm. @ruebot the codecov issue is separate from this PR right? I can merge now I'm happy?
@greebie

greebie approved these changes Sep 5, 2018
View changes

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 5, 2018

Member

Yep. CodeCov is separate. Feel free to merge this one if you're good with the license modifications.
Member

ruebot commented Sep 5, 2018

Yep. CodeCov is separate. Feel free to merge this one if you're good with the license modifications.

@greebie greebie merged commit b1f8eec into archivesunleashed:master Sep 5, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the ruebot:issue-51 branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment