Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop to version 0.74.0 #79
+1
−1
Conversation
depfu
bot
added
the
depfu
label
Aug 1, 2019
This comment has been minimized.
This comment has been minimized.
|
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/rubocop-0.74.0
branch
from
970203a
to
169a707
Aug 4, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Aug 4, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
ruebot
merged commit dcc59ca
into
master
Aug 4, 2019
depfu
bot
deleted the
depfu/update/rubocop-0.74.0
branch
Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedAug 1, 2019
•
edited
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
0.74.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 40 commits:
Cut 0.74Detect more interpolations[Fix #7242] Make Style/ConstantVisibility workAdd a description for `Metrics/LineLength`Remove unused node matchers in NodeSimplify Style/CommentedKeywordRemove unused node matchersFix autocorrection of UnneededSplatExpasion when Array.new with a block is assigned to a variable (#7222)[Fix #7235] Tell `elsif` from nested `if` in ConditionalAssignmentMerge pull request #6866 from koic/fix_false_positive_for_layout_indentation_widthMerge pull request #7234 from jonas054/7215_guard_clause_clarificationMerge pull request #7233 from buehmann/console-bundlerGive example code as non-modifier if too long for one line[Fix #7215] Make message from GuardClause more clear[Fix #6861] Fix a false positive for `Layout/IndentationWidth`Merge pull request #7232 from koic/make_line_length_aware_of_shebangUse bundle in bin/console[Fix #7128] Make `Metrics/LineLength` aware of shebang[Fix #5628] Rewrite SpaceInsideStringInterpolationSupport multi-character tokens in SurroundingSpaceRecognize tabs as surrounding spaceMerge pull request #7224 from jonas054/refactor_decrease_length_of_config_classMerge pull request #7225 from jonas054/7190_lower_case_drive_letterUse squiggly heredocs instead of strip_indent[Fix #7190] Support lower case drive letters on WindowsAdd missing documentation for ConfigValidatorChange name of ObsoleteConfig to ConfigObsoletionExtract ConfigValidator class from Config classExtract ObsoleteConfig class from Config classImprove test coverage of obsolete cops and parametersUse Forwardable mixin in Config class[Fix #7219] Support auto-correct for `Lint/ErbNewArguments`Make TrailingMethodEndStatement actually work (#7217)Change: SpaceAroundOperators To Work With ExtraSpacingChange: Introduce type Parameter For Assignments In SpaceAroundOperatorsChange: Extract aligned_with_preceding_assignment Into ModuleImprove expect_no_offenses[#5265] Make ExtraSpacing assignment alignment more robustUpdate manual with more information on --disable-uncorrectableFix VersionAdded of Style/MultilineWhenThenDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands