Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade engine_cart to version 2.3.0 #81
+1
−1
Conversation
depfu
bot
added
the
depfu
label
Aug 7, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Aug 7, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
ruebot
approved these changes
Aug 7, 2019
ruebot
merged commit ca97273
into
master
Aug 7, 2019
depfu
bot
deleted the
depfu/update/engine_cart-2.3.0
branch
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedAug 7, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Commits
See the full diff on Github. The new version differs by 5 commits:
Release v2.3.0Build the test gem using the rails generator directlyAdd a bunch of skips to the rails optionsAdd a little more debuggability to engine cart cachingUpdate build matrix (#94)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands