Skip to content

/cregg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of combining features #17

Closed
leeper opened this Issue Feb 19, 2019 · 5 comments

Comments

Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
2 participants
@leeper @mbarnfield
@leeper
Copy link
Owner

leeper commented Feb 19, 2019

Please specify whether your issue is about:

  • a possible bug
  • a question about package functionality
  • a suggested code or documentation change, improvement to the code, or feature request

It would be nice to demonstrate that if you want higher-order marginal means, you need to combine features together. So if you have two features with levels (A,B), (C,D), you need to create a new factor variable with levels (AC, AD, BC, BD). This is easily done with interaction().

@leeper leeper added enhancement good first issue labels Feb 19, 2019

@mbarnfield

This comment has been minimized.

Sign in to view
Copy link
Contributor

mbarnfield commented Mar 14, 2019

I've just seen this after sending a pull request in which I attempted to add some coverage of interactions. Am happy to add this as well/instead. Will it work for AMCEs (i.e., ACIEs) as well?

@mbarnfield mbarnfield referenced this issue Mar 14, 2019

Merged

Update Introduction.Rmd #21

@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner Author

leeper commented Mar 15, 2019

Thanks for that! Yes, those edits look good. This issue is about getting them in the documentation for cj_amce() (rather than the vignette). Want to send a separate PR with something like what you have here added to the docs? Tag the commit message with this issue number.
@mbarnfield

This comment has been minimized.

Sign in to view
Copy link
Contributor

mbarnfield commented Mar 15, 2019

Will do, thanks. I just put everything in the vignette initially as it was my first commit, and if there were issues I thought it would be better if they were all in one place!
@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner Author

leeper commented Mar 15, 2019

Totally fine! It's a nice addition to the vignette.

mbarnfield added a commit to mbarnfield/cregg that referenced this issue Mar 15, 2019

@mbarnfield
Adding interaction effects/feature combos (leeper#17) 
Addressing issue leeper#17

Also corrects/clarifies documentation on amce's ability to, and way of, calculating amces for constrained designs.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6a23acd

@mbarnfield mbarnfield referenced this issue Mar 15, 2019

Merged

Adding interaction effects/feature combos (#17) #23

0 of 6 tasks complete
@mbarnfield

This comment has been minimized.

Sign in to view
Copy link
Contributor

mbarnfield commented Mar 15, 2019

Done for amce(), will also do for cj() and mm()

mbarnfield added a commit to mbarnfield/cregg that referenced this issue Mar 15, 2019

@mbarnfield
Higher-order mms with feature combos (leeper#17) 
A few revisions to mm documentation, including examples of higher-order mm estimation (interactions/combinations) and calculating mms with feature constraints
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c17f6d9

mbarnfield added a commit to mbarnfield/cregg that referenced this issue Mar 15, 2019

@mbarnfield
Feature combos/interactions for cj () (leeper#17) 
Adds estimation of mms and amces for feature combinations/interactions in cj() (leeper#17)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
14411a8

@leeper leeper closed this Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.